jersey
  1. jersey
  2. JERSEY-664

Clumsy sentence in helloworld-osgi-webapp README file.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: 1.7
    • Component/s: examples
    • Labels:
      None

      Description

      Incidentally, I think it would be good to add a "samples" to your JIRA issue Components section (I used www here instead).

      The following sentence in the README: "The purpose of this resource is to show how to define multiple web resources within a web application, as in the OSGi environment the package name based configuration is not working yet", doesn't make sense after the comma. The sentence should rewritten or something, I don't know what "as in the OSGi environment the package name based configuration is not working yet" has to do with anything.

        Activity

        Hide
        gmazza added a comment -

        Five more problems found in this readme:

        1.) It says we should load this bundle in Felix:
        http://apache.opensourceresources.org//felix/org.apache.felix.eventadmin-1.2.6.jar

        That version is no longer available, it needs to be -1.2.8.jar

        2.) The text says: "To run the example, you would need to build the WAR file"
        Let us know the maven command to build it and deploy it. "mvn clean install" should be sufficient.

        3.) It says we should load this bundle in Felix:
        install file:war-bundle-1.5-SNAPSHOT.war

        But the project just generates war-bundle-1.5.war (as I see in my local Maven repo), so the SNAPSHOT portion should be removed above.

        4.) Another problem, even if I use that new name Felix can't load it:
        g! install file:war-bundle-1.5.war
        java.io.FileNotFoundException: war-bundle-1.5.war (The system cannot find the file specified)

        Because this file is not in my local felix folder. The README needs to be updated to tell the user to copy this WAR to the felix folder, or (preferably) give us a command to use so that it will load the WAR already installed in our local Maven repo.

        5.) Finally, the two links at the bottom of the README, telling us where we can see the resources, aren't working even after successful bundle deployment. They both return this error:

        HTTP ERROR 404

        Problem accessing /helloworld/webresources/another. Reason:

        NOT_FOUND

        Powered by Jetty://

        While the Felix command window had this to say (indicating it was properly running):

        g! start 5 7 8 9 10 11 19
        g! Mar 2, 2011 9:36:19 PM com.sun.jersey.server.impl.application.WebApplicationImpl _initiate
        INFO: Initiating Jersey application, version 'Jersey: 1.5-SNAPSHOT 01/12/2011 01:30 PM'

        It would be good to test again to make sure the bundles are working on your end. I'm using Maven 2.2.1, Windows 7, JDK 1.6 build 22.

        Show
        gmazza added a comment - Five more problems found in this readme: 1.) It says we should load this bundle in Felix: http://apache.opensourceresources.org//felix/org.apache.felix.eventadmin-1.2.6.jar That version is no longer available, it needs to be -1.2.8.jar 2.) The text says: "To run the example, you would need to build the WAR file" Let us know the maven command to build it and deploy it. "mvn clean install" should be sufficient. 3.) It says we should load this bundle in Felix: install file:war-bundle-1.5-SNAPSHOT.war But the project just generates war-bundle-1.5.war (as I see in my local Maven repo), so the SNAPSHOT portion should be removed above. 4.) Another problem, even if I use that new name Felix can't load it: g! install file:war-bundle-1.5.war java.io.FileNotFoundException: war-bundle-1.5.war (The system cannot find the file specified) Because this file is not in my local felix folder. The README needs to be updated to tell the user to copy this WAR to the felix folder, or (preferably) give us a command to use so that it will load the WAR already installed in our local Maven repo. 5.) Finally, the two links at the bottom of the README, telling us where we can see the resources, aren't working even after successful bundle deployment. They both return this error: HTTP ERROR 404 Problem accessing /helloworld/webresources/another. Reason: NOT_FOUND Powered by Jetty:// While the Felix command window had this to say (indicating it was properly running): g! start 5 7 8 9 10 11 19 g! Mar 2, 2011 9:36:19 PM com.sun.jersey.server.impl.application.WebApplicationImpl _initiate INFO: Initiating Jersey application, version 'Jersey: 1.5-SNAPSHOT 01/12/2011 01:30 PM' It would be good to test again to make sure the bundles are working on your end. I'm using Maven 2.2.1, Windows 7, JDK 1.6 build 22.
        Hide
        jbenoit added a comment -

        self assigning

        Show
        jbenoit added a comment - self assigning
        Hide
        jbenoit added a comment -

        select samples Component:
        Thanks for the suggestion to "add a samples to your JIRA issue Components section"

        Show
        jbenoit added a comment - select samples Component: Thanks for the suggestion to "add a samples to your JIRA issue Components section"
        Hide
        jbenoit added a comment -

        Regarding:
        "1.) It says we should load this bundle in Felix:
        http://apache.opensourceresources.org//felix/org.apache.felix.eventadmin-1.2.6.jar
        That version is no longer available, it needs to be -1.2.8.jar"

        README.html now says to use these versions:
        g! install http://repo2.maven.org/maven2/org/apache/felix/org.apache.felix.configadmin/1.2.8/org.apache.felix.configadmin-1.2.8.jar
        Bundle ID: 5
        g! install http://repo1.maven.org/maven2/org/apache/felix/org.apache.felix.eventadmin/1.2.10/org.apache.felix.eventadmin-1.2.10.jar

        Regarding:
        "2.) The text says: "To run the example, you would need to build the WAR file"
        Let us know the maven command to build it and deploy it. "mvn clean install" should be sufficient."

        README.html says:
        <h2>Running the Example</h2>
        <p>To run the example, you would need to build the WAR file
        and install it to an OSGi runtime (e.g. Apache Felix) together with other OSGi modules.
        Look at the attached <tt>functional-test</tt> module for details on the programatical runtime configuration.
        To build the war archive and run the tests, you can just launch
        <pre>%mvn clean install
        </pre>

        Regarding:
        "4.) Another problem, even if I use that new name Felix can't load it:
        g! install file:war-bundle-1.5.war
        java.io.FileNotFoundException: war-bundle-1.5.war (The system cannot find the file specified)
        Because this file is not in my local felix folder. The README needs to be updated to tell the user to copy this WAR to the felix folder, or (preferably) give us a command to use so that it will load the WAR already installed in our local Maven repo."

        README.html says:
        %unzip ~/Downloads/org.apache.felix.main.distribution-3.0.9.zip
        %cp war-bundle/target/war-bundle*war felix-framework-3.0.9
        %cd felix-framework-3.0.9
        %java -jar bin/felix.jar

        Regarding:
        "5.) Finally, the two links at the bottom of the README, telling us where we can see the resources, aren't working even after successful bundle deployment. They both return this error:

        HTTP ERROR 404

        Problem accessing /helloworld/webresources/another. Reason:

        NOT_FOUND

        Powered by Jetty://

        While the Felix command window had this to say (indicating it was properly running):

        g! start 5 7 8 9 10 11 19
        g! Mar 2, 2011 9:36:19 PM com.sun.jersey.server.impl.application.WebApplicationImpl _initiate
        INFO: Initiating Jersey application, version 'Jersey: 1.5-SNAPSHOT 01/12/2011 01:30 PM'

        It would be good to test again to make sure the bundles are working on your end. I'm using Maven 2.2.1, Windows 7, JDK 1.6 build 22. "

        This sample tested okay using the latest README.html on windows XP, using Maven 2.2.1, and java version "1.6.0_23"
        Java(TM) SE Runtime Environment (build 1.6.0_23-b05)
        Java HotSpot(TM) Client VM (build 19.0-b09, mixed mode, sharing)

        both resources were available at :
        http://localhost:8080/helloworld/webresources/helloworld
        http://localhost:8080/helloworld/webresources/another

        Show
        jbenoit added a comment - Regarding: "1.) It says we should load this bundle in Felix: http://apache.opensourceresources.org//felix/org.apache.felix.eventadmin-1.2.6.jar That version is no longer available, it needs to be -1.2.8.jar" README.html now says to use these versions: g! install http://repo2.maven.org/maven2/org/apache/felix/org.apache.felix.configadmin/1.2.8/org.apache.felix.configadmin-1.2.8.jar Bundle ID: 5 g! install http://repo1.maven.org/maven2/org/apache/felix/org.apache.felix.eventadmin/1.2.10/org.apache.felix.eventadmin-1.2.10.jar Regarding: "2.) The text says: "To run the example, you would need to build the WAR file" Let us know the maven command to build it and deploy it. "mvn clean install" should be sufficient." README.html says: <h2>Running the Example</h2> <p>To run the example, you would need to build the WAR file and install it to an OSGi runtime (e.g. Apache Felix) together with other OSGi modules. Look at the attached <tt>functional-test</tt> module for details on the programatical runtime configuration. To build the war archive and run the tests, you can just launch <pre>%mvn clean install </pre> Regarding: "4.) Another problem, even if I use that new name Felix can't load it: g! install file:war-bundle-1.5.war java.io.FileNotFoundException: war-bundle-1.5.war (The system cannot find the file specified) Because this file is not in my local felix folder. The README needs to be updated to tell the user to copy this WAR to the felix folder, or (preferably) give us a command to use so that it will load the WAR already installed in our local Maven repo." README.html says: %unzip ~/Downloads/org.apache.felix.main.distribution-3.0.9.zip %cp war-bundle/target/war-bundle*war felix-framework-3.0.9 %cd felix-framework-3.0.9 %java -jar bin/felix.jar Regarding: "5.) Finally, the two links at the bottom of the README, telling us where we can see the resources, aren't working even after successful bundle deployment. They both return this error: HTTP ERROR 404 Problem accessing /helloworld/webresources/another. Reason: NOT_FOUND Powered by Jetty:// While the Felix command window had this to say (indicating it was properly running): g! start 5 7 8 9 10 11 19 g! Mar 2, 2011 9:36:19 PM com.sun.jersey.server.impl.application.WebApplicationImpl _initiate INFO: Initiating Jersey application, version 'Jersey: 1.5-SNAPSHOT 01/12/2011 01:30 PM' It would be good to test again to make sure the bundles are working on your end. I'm using Maven 2.2.1, Windows 7, JDK 1.6 build 22. " This sample tested okay using the latest README.html on windows XP, using Maven 2.2.1, and java version "1.6.0_23" Java(TM) SE Runtime Environment (build 1.6.0_23-b05) Java HotSpot(TM) Client VM (build 19.0-b09, mixed mode, sharing) both resources were available at : http://localhost:8080/helloworld/webresources/helloworld http://localhost:8080/helloworld/webresources/another
        Hide
        jbenoit added a comment -

        fixed item number 1)., no longer required to state "as in the OSGi environment the package name based configuration is not working yet"

        fixed item number 3)., should reference only "war-bundle-1.6.war" not "war-bundle-1.6-ea06.war"
        i.e. remove all references to "-ea06", updated to match current release. added note that version string can change to a different version of Jersey. for future, to track ideal way of documenting jersey version string used in readme to install jersey bundles, see http://java.net/jira/browse/JERSEY-723

        fixed item number 4)., to tell the user to copy this WAR to the felix folder. unaware of felix command/option that will load the WAR already installed in our local Maven repo, other than approach similar to what we already do, sans copying it locally to felix install dir. i.e.

        g! install
        file:/C:/jersey/samples/helloworld-osgi-webapp/war-bundle/target/war-bundle-1.7-SNAPSHOT.war

        but this is not platform agnostic. since this is not significantly better then the current copy approach, will stick with that.

        Sending README.html
        Transmitting file data .
        Committed revision 4977.

        Show
        jbenoit added a comment - fixed item number 1)., no longer required to state "as in the OSGi environment the package name based configuration is not working yet" fixed item number 3)., should reference only "war-bundle-1.6.war" not "war-bundle-1.6-ea06.war" i.e. remove all references to "-ea06", updated to match current release. added note that version string can change to a different version of Jersey. for future, to track ideal way of documenting jersey version string used in readme to install jersey bundles, see http://java.net/jira/browse/JERSEY-723 fixed item number 4)., to tell the user to copy this WAR to the felix folder. unaware of felix command/option that will load the WAR already installed in our local Maven repo, other than approach similar to what we already do, sans copying it locally to felix install dir. i.e. g! install file:/C:/jersey/samples/helloworld-osgi-webapp/war-bundle/target/war-bundle-1.7-SNAPSHOT.war but this is not platform agnostic. since this is not significantly better then the current copy approach, will stick with that. Sending README.html Transmitting file data . Committed revision 4977.

          People

          • Assignee:
            jbenoit
            Reporter:
            gmazza
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: