jms-spec
  1. jms-spec
  2. JMS_SPEC-98

Fix findbugs warnings in JMSException, JMSRuntimeException, QueueRequestor, TopicRequestor

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1
    • Fix Version/s: 2.0PD, 2.0
    • Labels:
      None

      Description

      The following JMS 1.1 classes give the following findbugs warnings:

      javax/jms/JMSException.java:86: UG_SYNC_SET_UNSYNC_GET: 
      javax.jms.JMSException.getLinkedException() is unsynchronized, 
      javax.jms.JMSException.setLinkedException(Exception) is synchronized
      
      javax/jms/QueueRequestor.java:62: URF_UNREAD_FIELD:
      Unread field: javax.jms.QueueRequestor.queue
      
      java/javax/jms/TopicRequestor.java:61: URF_UNREAD_FIELD: Unread field:
      javax.jms.TopicRequestor.topic
      

      It should be possible for fix all these without breaking backwards compatibility.

      Also, the following new JMS 2.0 class givs the following findbugs warnings:

      javax/jms/JMSRuntimeException.java:118: UG_SYNC_SET_UNSYNC_GET:
      javax.jms.JMSRuntimeException.getLinkedException() is unsynchronized,
      javax.jms.JMSRuntimeException.setLinkedException(Exception) is synchronized
      

      This should be fixed.

        Activity

        Nigel Deakin created issue -
        Nigel Deakin made changes -
        Field Original Value New Value
        Description The following JMS 1.1 classes give the following findbugs warnings:

        {noformat}
        javax/jms/JMSException.java:86: UG_SYNC_SET_UNSYNC_GET:
        javax.jms.JMSException.getLinkedException() is unsynchronized,
        javax.jms.JMSException.setLinkedException(Exception) is synchronized

        javax/jms/QueueRequestor.java:62: URF_UNREAD_FIELD: Unread field: javax.jms.QueueRequestor.queue

        java/javax/jms/TopicRequestor.java:61: URF_UNREAD_FIELD: Unread field: javax.jms.TopicRequestor.topic
        {noformat}

        It should be possible for fix all these without breaking backwards compatibility.

        Also, the following new JMS 2.0 class givs the following findbugs warnings:

        {noformat}
        javax/jms/JMSRuntimeException.java:118: UG_SYNC_SET_UNSYNC_GET:
        javax.jms.JMSRuntimeException.getLinkedException() is unsynchronized, javax.jms.JMSRuntimeException.setLinkedException(Exception) is synchronized
        {noformat}

        This should be fixed.
        The following JMS 1.1 classes give the following findbugs warnings:

        {noformat}
        javax/jms/JMSException.java:86: UG_SYNC_SET_UNSYNC_GET:
        javax.jms.JMSException.getLinkedException() is unsynchronized,
        javax.jms.JMSException.setLinkedException(Exception) is synchronized

        javax/jms/QueueRequestor.java:62: URF_UNREAD_FIELD:
        Unread field: javax.jms.QueueRequestor.queue

        java/javax/jms/TopicRequestor.java:61: URF_UNREAD_FIELD: Unread field:
        javax.jms.TopicRequestor.topic
        {noformat}

        It should be possible for fix all these without breaking backwards compatibility.

        Also, the following new JMS 2.0 class givs the following findbugs warnings:

        {noformat}
        javax/jms/JMSRuntimeException.java:118: UG_SYNC_SET_UNSYNC_GET:
        javax.jms.JMSRuntimeException.getLinkedException() is unsynchronized,
        javax.jms.JMSRuntimeException.setLinkedException(Exception) is synchronized
        {noformat}

        This should be fixed.
        Nigel Deakin made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.0 [ 14692 ]
        Resolution Fixed [ 1 ]
        Nigel Deakin made changes -
        Tags pd20-veryminor
        Nigel Deakin made changes -
        Tags pd20-added
        Nigel Deakin made changes -
        Fix Version/s 2.0PD [ 16049 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Nigel Deakin
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: