jsip
  1. jsip
  2. JSIP-378

Race condition on ACK creation and 200 OK retransmission could lead to messed up branch id in the retransmission

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      200 OK retransmission arrives with the correct branch id in the Via Header but when passed up to the application it has changed.

      It seems actually we copy the Via Header in a SIPDialog attribute called lastResponseTopMostVia and it is used in the createAck method of SIPDialog. But it is modified there which could cause this.

      See Issue http://code.google.com/p/mobicents/issues/detail?id=2453#c20

        Activity

        Hide
        deruelle_jean added a comment -

        Attaching patch for review. cloning the via header to keep it locally so that it can be modified in the ACK without impacting the 200 retransmission. TCK and testsuite green. Verified by user and seems OK

        Show
        deruelle_jean added a comment - Attaching patch for review. cloning the via header to keep it locally so that it can be modified in the ACK without impacting the 200 retransmission. TCK and testsuite green. Verified by user and seems OK
        Hide
        mranga added a comment -

        Patch looks good. Please commit. Thanks.

        Show
        mranga added a comment - Patch looks good. Please commit. Thanks.
        Hide
        deruelle_jean added a comment -

        Patch committed in revision 1909

        Show
        deruelle_jean added a comment - Patch committed in revision 1909

          People

          • Assignee:
            Unassigned
            Reporter:
            deruelle_jean
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: