jsp
  1. jsp
  2. JSP-18

Add setExpressionFactory method to JspApplicationContextImpl Class

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Add setExpressionFactory method to JspApplicationContextImpl

        Activity

        Hide
        kchung added a comment -

        1. How bad is its impact? (Severity)

        This change is needed to pass the weld tck tests.

        2. How often does it happen? Will many users see this problem? (Frequency)

        Without this change, an important functionality in weld will not work. All users will be affected.

        3. How much effort is required to fix it? (Cost)

        The effort is minimal: only need to add a new method to an implementation class.

        misto:runtime%svn diff
        Index: JspApplicationContextImpl.java
        ===================================================================
        — JspApplicationContextImpl.java (revision 1347)
        +++ JspApplicationContextImpl.java (working copy)
        @@ -110,6 +110,10 @@
        return expressionFactory;
        }

        + public void setExpressionFactory(ExpressionFactory expressionFactory)

        { + this.expressionFactory = expressionFactory; + }

        +
        public void addELContextListener(ELContextListener listener)

        { listeners.add(listener); }

        4. What is the risk of fixing it and how will the risk be mitigated? (Risk)

        Risk is also minimal. Adding a new method would not affect existing running codes.

        Show
        kchung added a comment - 1. How bad is its impact? (Severity) This change is needed to pass the weld tck tests. 2. How often does it happen? Will many users see this problem? (Frequency) Without this change, an important functionality in weld will not work. All users will be affected. 3. How much effort is required to fix it? (Cost) The effort is minimal: only need to add a new method to an implementation class. misto:runtime%svn diff Index: JspApplicationContextImpl.java =================================================================== — JspApplicationContextImpl.java (revision 1347) +++ JspApplicationContextImpl.java (working copy) @@ -110,6 +110,10 @@ return expressionFactory; } + public void setExpressionFactory(ExpressionFactory expressionFactory) { + this.expressionFactory = expressionFactory; + } + public void addELContextListener(ELContextListener listener) { listeners.add(listener); } 4. What is the risk of fixing it and how will the risk be mitigated? (Risk) Risk is also minimal. Adding a new method would not affect existing running codes.
        Hide
        kchung added a comment -

        Fixed in jsp in revision 1348.
        Integrated into glassfish 3.1 in revision 44380.

        Show
        kchung added a comment - Fixed in jsp in revision 1348. Integrated into glassfish 3.1 in revision 44380.

          People

          • Assignee:
            kchung
            Reporter:
            rogerk
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: