maven-glassfish-plugin
  1. maven-glassfish-plugin
  2. MAVEN_GLASSFISH_PLUGIN-14

presence of asadmin shell script file prevents asadmin.bat execution in AsadminCommand

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: current
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:

      Windows

      Description

      Glassfish 3.1.2 installation on windows will place both asadmin and asadmin.bat in the bin folder for glassfish. The detection logic in AsadminCommand is slightly broken:

      81 if (!asadmin.exists() && System.getProperty("os.name").contains("indows"))

      { 82 asadmin = new File(binDir, "asadmin.bat"); 83 }

      asadmin shell script will be found, and regardless of the operating system being windows, the wrong file will be executed.
      the check for the presence of asadmin is not required, I think, and simply the check for windows should be sufficient to run the .bat command instead.

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            Unassigned
            Reporter:
            mgabrielm2
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: