Issue Details (XML | Word | Printable)

Key: METRO-6
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Critical Critical
Assignee: Martin Grebac
Reporter: kohsuke
Votes: 0
Watchers: 0

If you were logged in you would be able to see more operations.

Source jars missing in Maven repositories

Created: 28/Oct/08 10:43 AM   Updated: 09/Dec/11 09:42 AM   Resolved: 09/Dec/11 09:42 AM
Component/s: www
Affects Version/s: current
Fix Version/s: 2.2

Time Tracking:
Not Specified


Operating System: All
Platform: All

Issuezilla Id: 6
Participants: kohsuke, Martin Grebac and ritzmann

 Description  « Hide

Metro only pushes binary jar files but not source jars. This substantially
reduces the debuggability of Metro, and lowers the likelihood that we get
contributions/patches from external developers.

ritzmann added a comment - 28/Oct/08 11:36 AM

Do you have a pointer to the conventions that Maven normally uses to create
source bundles?

This will likely take some time to implement since the build scripts that
create source bundles have fallen into disrepair.

kohsuke added a comment - 28/Oct/08 04:47 PM

See as an example.

In Maven jargon, a source jar has the "sources" classifier (or in plain English,
it ends with "-sources.jar"), and contains .java files where you normally expect
class files. Unlike source bundles often seen in the wild from Ant builds, there
shall be no build script, no "src" directory or any other intermediate
directories. Just source files in the package structure.

Compared to the source bundle, which normally retains the original source tree
structure, build script, and associated jar files, the source jar takes a
different form.

For a starter, it's OK for the source jar to be incomplete. If you can point me
to the part of the build script in WSIT that pushes jars to Maven repository,
I'm happy to take a shot at fixing this.

ritzmann added a comment - 29/Oct/08 02:01 AM

We typically run something like "ant jar" from the wsit main directory,
followed by a "mvn -f etc/maven/pom.xml deploy". The POMs simply pick up the
JARs from the Ant run. We have a src-zip target in the main build.xml but what
it zips is in parts incomplete and in other parts more than what we have in the
deployed JARs. (And the contents certainly do not follow Maven conventions.)

kohsuke added a comment - 29/Oct/08 10:21 AM

Which branch of WSIT workspace should I attempt a fix in?

ritzmann added a comment - 29/Oct/08 10:30 AM


Martin Grebac added a comment - 09/Dec/11 09:42 AM

All the artifacts source/javadoc are deployed and synced to central starting with 2.2.