metro
  1. metro
  2. METRO-6

Source jars missing in Maven repositories

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: current
    • Fix Version/s: 2.2
    • Component/s: www
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      6

      Description

      Metro only pushes binary jar files but not source jars. This substantially
      reduces the debuggability of Metro, and lowers the likelihood that we get
      contributions/patches from external developers.

        Activity

        Hide
        ritzmann added a comment -

        Do you have a pointer to the conventions that Maven normally uses to create
        source bundles?

        This will likely take some time to implement since the build scripts that
        create source bundles have fallen into disrepair.

        Show
        ritzmann added a comment - Do you have a pointer to the conventions that Maven normally uses to create source bundles? This will likely take some time to implement since the build scripts that create source bundles have fallen into disrepair.
        Hide
        kohsuke added a comment -

        See http://download.java.net/maven/1/com.sun.xml.bind/java-sources/ as an example.

        In Maven jargon, a source jar has the "sources" classifier (or in plain English,
        it ends with "-sources.jar"), and contains .java files where you normally expect
        class files. Unlike source bundles often seen in the wild from Ant builds, there
        shall be no build script, no "src" directory or any other intermediate
        directories. Just source files in the package structure.

        Compared to the source bundle, which normally retains the original source tree
        structure, build script, and associated jar files, the source jar takes a
        different form.

        For a starter, it's OK for the source jar to be incomplete. If you can point me
        to the part of the build script in WSIT that pushes jars to Maven repository,
        I'm happy to take a shot at fixing this.

        Show
        kohsuke added a comment - See http://download.java.net/maven/1/com.sun.xml.bind/java-sources/ as an example. In Maven jargon, a source jar has the "sources" classifier (or in plain English, it ends with "-sources.jar"), and contains .java files where you normally expect class files. Unlike source bundles often seen in the wild from Ant builds, there shall be no build script, no "src" directory or any other intermediate directories. Just source files in the package structure. Compared to the source bundle, which normally retains the original source tree structure, build script, and associated jar files, the source jar takes a different form. For a starter, it's OK for the source jar to be incomplete. If you can point me to the part of the build script in WSIT that pushes jars to Maven repository, I'm happy to take a shot at fixing this.
        Hide
        ritzmann added a comment -

        We typically run something like "ant jar" from the wsit main directory,
        followed by a "mvn -f etc/maven/pom.xml deploy". The POMs simply pick up the
        JARs from the Ant run. We have a src-zip target in the main build.xml but what
        it zips is in parts incomplete and in other parts more than what we have in the
        deployed JARs. (And the contents certainly do not follow Maven conventions.)

        Show
        ritzmann added a comment - We typically run something like "ant jar" from the wsit main directory, followed by a "mvn -f etc/maven/pom.xml deploy". The POMs simply pick up the JARs from the Ant run. We have a src-zip target in the main build.xml but what it zips is in parts incomplete and in other parts more than what we have in the deployed JARs. (And the contents certainly do not follow Maven conventions.)
        Hide
        kohsuke added a comment -

        Which branch of WSIT workspace should I attempt a fix in?

        Show
        kohsuke added a comment - Which branch of WSIT workspace should I attempt a fix in?
        Hide
        ritzmann added a comment -

        HEAD

        Show
        ritzmann added a comment - HEAD
        Hide
        Martin Grebac added a comment -

        All the artifacts source/javadoc are deployed and synced to central starting with 2.2.

        Show
        Martin Grebac added a comment - All the artifacts source/javadoc are deployed and synced to central starting with 2.2.

          People

          • Assignee:
            Martin Grebac
            Reporter:
            kohsuke
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: