opends
  1. opends
  2. OPENDS-616

Incorrect line number reported in makeldif error messages

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: pre-1.0
    • Fix Version/s: untargetted
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

      Description

      The template that reproduces the error is attached. It looks like it was trying
      to parse an attribute replacement tag for template "messaging52person" when the
      error occurred. The attribute givenName is found in a parent template. Since
      inheritance is not currently supported, this behavior is expected. However, the
      line number in the error message is incorrect. It reports the error occurred on
      line 71 when the tag was actually used on line 62.

        Activity

        Hide
        boli added a comment -

        Created an attachment (id=24)
        Sample template that reproduces the error

        Show
        boli added a comment - Created an attachment (id=24) Sample template that reproduces the error
        Hide
        bdamm added a comment -

        I've started to investigate this issue but more work needs to be done before I
        can replicate the problem.

        Show
        bdamm added a comment - I've started to investigate this issue but more work needs to be done before I can replicate the problem.
        Hide
        bdamm added a comment -

        I've replicated the problem in my environment and am debugging it now.

        Show
        bdamm added a comment - I've replicated the problem in my environment and am debugging it now.
        Hide
        bdamm added a comment -

        The problem appears to be a typo on line 950 of
        server/org/opends/server/tools/makeldif/TemplateFile.java

        Template t = parseTemplateDefinition(templateLines, lineNumber,
        templateFileIncludeTags,
        templateFileConstants, warnings);

        Should read:
        Template t = parseTemplateDefinition(templateLines, startLineNumber,
        templateFileIncludeTags,
        templateFileConstants, warnings);

        I'll begin proceedings to commit this patch tomorrow.

        Show
        bdamm added a comment - The problem appears to be a typo on line 950 of server/org/opends/server/tools/makeldif/TemplateFile.java Template t = parseTemplateDefinition(templateLines, lineNumber, templateFileIncludeTags, templateFileConstants, warnings); Should read: Template t = parseTemplateDefinition(templateLines, startLineNumber, templateFileIncludeTags, templateFileConstants, warnings); I'll begin proceedings to commit this patch tomorrow.
        Hide
        bdamm added a comment -

        Created an attachment (id=76)
        Patch including fix and test case; not yet approved for inclusion.

        Show
        bdamm added a comment - Created an attachment (id=76) Patch including fix and test case; not yet approved for inclusion.
        Hide
        neil_a_wilson added a comment -

        I have committed the patch provided by Benjamin Damm.

        $ svn commit src/server/org/opends/server/tools/makeldif/TemplateFile.java
        tests/unit-tests-testng/src/server/org/opends/server/tools/makeldif
        Sending src/server/org/opends/server/tools/makeldif/TemplateFile.java
        Adding tests/unit-tests-testng/src/server/org/opends/server/tools/makeldif
        Adding
        tests/unit-tests-testng/src/server/org/opends/server/tools/makeldif/MakeLDIFTestCase.java
        Transmitting file data ..
        Committed revision 571.

        Show
        neil_a_wilson added a comment - I have committed the patch provided by Benjamin Damm. $ svn commit src/server/org/opends/server/tools/makeldif/TemplateFile.java tests/unit-tests-testng/src/server/org/opends/server/tools/makeldif Sending src/server/org/opends/server/tools/makeldif/TemplateFile.java Adding tests/unit-tests-testng/src/server/org/opends/server/tools/makeldif Adding tests/unit-tests-testng/src/server/org/opends/server/tools/makeldif/MakeLDIFTestCase.java Transmitting file data .. Committed revision 571.
        Hide
        bdamm added a comment -

        Thank you Neil!

        What should happen with this issue now? I'll mark it resolved/fixed and wait
        for QA to complete.

        Show
        bdamm added a comment - Thank you Neil! What should happen with this issue now? I'll mark it resolved/fixed and wait for QA to complete.
        Hide
        neil_a_wilson added a comment -

        Yes, the correct process is to mark the issue as FIXED and then QA can look at
        it and if they're satisfied they will change it to VERIFIED. There shouldn't be
        anything else that you need to do for this issue.

        Show
        neil_a_wilson added a comment - Yes, the correct process is to mark the issue as FIXED and then QA can look at it and if they're satisfied they will change it to VERIFIED. There shouldn't be anything else that you need to do for this issue.
        Hide
        mkc added a comment -

        This fixes the code to bring it in line with what is expected. The doc is not
        therefore affected.

        Show
        mkc added a comment - This fixes the code to bring it in line with what is expected. The doc is not therefore affected.

          People

          • Assignee:
            bdamm
            Reporter:
            boli
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: