Issue Details (XML | Word | Printable)

Key: PORTLETSPEC3-17
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: msnicklous
Reporter: msnicklous
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
portletspec3

Errata: Correction in setNextPossiblePortletModes

Created: 03/May/13 02:13 PM   Updated: 16/Aug/13 08:22 PM   Resolved: 16/Aug/13 08:22 PM
Component/s: JSR 286 Portlet Specification Errata
Affects Version/s: None
Fix Version/s: None

Time Tracking:
Not Specified

Tags:
Participants: julien_viet, msnicklous and Neil Griffin


 Description  « Hide

I believe we need a correction here, see below.

Original:
-------------------------
void setNextPossiblePortletModes(java.util.Collection<PortletMode> portletModes)
-------------------------

Corrected:
-------------------------
void setNextPossiblePortletModes(java.util.Collection<? extends PortletMode> portletModes)
-------------------------



msnicklous added a comment - 16/Aug/13 08:22 PM

Updated method signature & javadoc comment here.


Neil Griffin added a comment - 14/May/13 04:20 AM

+1 Seems like a nice feature in that it adds some flexibility:

List<PortletMode> portletModes = new ArrayList<PortletMode>();
response.setNextPossiblePortletModes(portletModes);

List<ExtendedPortletMode> extendedPortletModes = new ArrayList<ExtendedPortletMode>();
response.setNextPossiblePortletModes(extendedPortletModes);

julien_viet added a comment - 10/May/13 08:21 AM

I think this would be only useful if people were using PortletMode subclasses.

This makes the API (a bit) more complex to understand and does not bring much value imho.