portletspec3
  1. portletspec3
  2. PORTLETSPEC3-17

Errata: Correction in setNextPossiblePortletModes

    Details

      Description

      I believe we need a correction here, see below.

      Original:
      -------------------------
      void setNextPossiblePortletModes(java.util.Collection<PortletMode> portletModes)
      -------------------------

      Corrected:
      -------------------------
      void setNextPossiblePortletModes(java.util.Collection<? extends PortletMode> portletModes)
      -------------------------

        Activity

        msnicklous created issue -
        Hide
        julien_viet added a comment -

        I think this would be only useful if people were using PortletMode subclasses.

        This makes the API (a bit) more complex to understand and does not bring much value imho.

        Show
        julien_viet added a comment - I think this would be only useful if people were using PortletMode subclasses. This makes the API (a bit) more complex to understand and does not bring much value imho.
        Hide
        Neil Griffin added a comment -

        +1 Seems like a nice feature in that it adds some flexibility:

        List<PortletMode> portletModes = new ArrayList<PortletMode>();
        response.setNextPossiblePortletModes(portletModes);
        
        List<ExtendedPortletMode> extendedPortletModes = new ArrayList<ExtendedPortletMode>();
        response.setNextPossiblePortletModes(extendedPortletModes);
        
        Show
        Neil Griffin added a comment - +1 Seems like a nice feature in that it adds some flexibility: List<PortletMode> portletModes = new ArrayList<PortletMode>(); response.setNextPossiblePortletModes(portletModes); List<ExtendedPortletMode> extendedPortletModes = new ArrayList<ExtendedPortletMode>(); response.setNextPossiblePortletModes(extendedPortletModes);
        msnicklous made changes -
        Field Original Value New Value
        Assignee msnicklous [ msnicklous ]
        Hide
        msnicklous added a comment -

        Updated method signature & javadoc comment here.

        Show
        msnicklous added a comment - Updated method signature & javadoc comment here .
        msnicklous made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            msnicklous
            Reporter:
            msnicklous
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: