sailfin
  1. sailfin
  2. SAILFIN-1271

add --properties option for AR deployment

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: milestone 1
    • Component/s: admin
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      1,271

      Description

      The JSR289 spec opens up the possibility to pass initialisation properties to
      Application Routers, but does not define how these properties should be provided
      to the container.
      The proposal here is to support these configuration properties for Application
      Routers expliclity deployed using an asadmin deploy command. The --properties
      parameter can be used for this. These properties should then be stored in the
      domain.xml file, since it is not known upfront which of the (potentially many)
      deployed ARs is actually selected. The application can even switch between ARs
      by setting a system property.

      PS.Please also provide some advice on how to access the properties for a given
      AR from the code of the application dispatcher that does the actual
      instantiation and initialisation of the AR.

        Activity

        Hide
        Yamini K B added a comment -

        Need to add support for --properties option to 'deploy' command. These
        properties should be applicable for the extension-module element.

        Show
        Yamini K B added a comment - Need to add support for --properties option to 'deploy' command. These properties should be applicable for the extension-module element.
        Hide
        swethadn added a comment -

        The code for the property option is not implemented for the extension module.

        Show
        swethadn added a comment - The code for the property option is not implemented for the extension module.
        Hide
        swethadn added a comment -

        //The property option is sent as a Map in the request from
        PEDeploymentService.java and implemented for the extension module in
        DeploymentServiceUtils.java
        Issue number: 1271
        Obtained from:
        Submitted by:
        Reviewed by: Prasad, Yamini
        Tests Run : Sailfin QL,
        Sailfin Cluster QL,
        Glassfish QL,
        Dev tests for deployment :
        simpleSipApp_startup,
        simpleSipApp_deploy,
        simpleSipApp_undeploy.

        Checking in
        admin-cli/commands/src/java/com/sun/enterprise/cli/commands/CLIDescriptor.xml;
        /cvs/glassfish/admin-cli/commands/src/java/com/sun/enterprise/cli/commands/CLIDescriptor.xml,v
        <-- CLIDescriptor.xml
        new revision: 1.70.2.3; previous revision: 1.70.2.2
        done
        Checking in
        admin-cli/commands/src/java/com/sun/enterprise/cli/commands/DeployCommand.java;
        /cvs/glassfish/admin-cli/commands/src/java/com/sun/enterprise/cli/commands/DeployCommand.java,v
        <-- DeployCommand.java
        new revision: 1.11.6.1; previous revision: 1.11
        done
        Checking in
        appserv-commons/src/java/com/sun/enterprise/deployment/util/DeploymentProperties.java;
        /cvs/glassfish/appserv-commons/src/java/com/sun/enterprise/deployment/util/DeploymentProperties.java,v
        <-- DeploymentProperties.java
        new revision: 1.13.6.1; previous revision: 1.13
        done
        Checking in
        appserv-core/src/java/com/sun/enterprise/deployment/phasing/DeploymentServiceUtils.java;
        /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/deployment/phasing/DeploymentServiceUtils.java,v
        <-- DeploymentServiceUtils.java
        new revision: 1.36.2.5; previous revision: 1.36.2.4
        done
        Checking in
        appserv-core/src/java/com/sun/enterprise/deployment/phasing/PEDeploymentService.java;
        /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/deployment/phasing/PEDeploymentService.java,v
        <-- PEDeploymentService.java
        new revision: 1.21.2.3; previous revision: 1.21.2.2
        done

        Show
        swethadn added a comment - //The property option is sent as a Map in the request from PEDeploymentService.java and implemented for the extension module in DeploymentServiceUtils.java Issue number: 1271 Obtained from: Submitted by: Reviewed by: Prasad, Yamini Tests Run : Sailfin QL, Sailfin Cluster QL, Glassfish QL, Dev tests for deployment : simpleSipApp_startup, simpleSipApp_deploy, simpleSipApp_undeploy. Checking in admin-cli/commands/src/java/com/sun/enterprise/cli/commands/CLIDescriptor.xml; /cvs/glassfish/admin-cli/commands/src/java/com/sun/enterprise/cli/commands/CLIDescriptor.xml,v <-- CLIDescriptor.xml new revision: 1.70.2.3; previous revision: 1.70.2.2 done Checking in admin-cli/commands/src/java/com/sun/enterprise/cli/commands/DeployCommand.java; /cvs/glassfish/admin-cli/commands/src/java/com/sun/enterprise/cli/commands/DeployCommand.java,v <-- DeployCommand.java new revision: 1.11.6.1; previous revision: 1.11 done Checking in appserv-commons/src/java/com/sun/enterprise/deployment/util/DeploymentProperties.java; /cvs/glassfish/appserv-commons/src/java/com/sun/enterprise/deployment/util/DeploymentProperties.java,v <-- DeploymentProperties.java new revision: 1.13.6.1; previous revision: 1.13 done Checking in appserv-core/src/java/com/sun/enterprise/deployment/phasing/DeploymentServiceUtils.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/deployment/phasing/DeploymentServiceUtils.java,v <-- DeploymentServiceUtils.java new revision: 1.36.2.5; previous revision: 1.36.2.4 done Checking in appserv-core/src/java/com/sun/enterprise/deployment/phasing/PEDeploymentService.java; /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/deployment/phasing/PEDeploymentService.java,v <-- PEDeploymentService.java new revision: 1.21.2.3; previous revision: 1.21.2.2 done
        Hide
        swethadn added a comment -

        Reassigning the issue to docs .

        Show
        swethadn added a comment - Reassigning the issue to docs .
        Hide
        swethadn added a comment -

        This issue needs to be documented as new --property option is added to the
        deploy command .

        Show
        swethadn added a comment - This issue needs to be documented as new --property option is added to the deploy command .
        Hide
        chinmayee_srivathsa added a comment -

        Created new sailfin-specific deploy man page.

        RCS file: /cvs/sailfin/administration/src/main/sman/cat1/deploy.1,v
        done
        Checking in deploy.1;
        /cvs/sailfin/administration/src/main/sman/cat1/deploy.1,v <-- deploy.1
        initial revision: 1.1
        done

        RCS file: /cvs/sailfin/administration/src/main/sman/man1/deploy.1,v
        done
        Checking in deploy.1;
        /cvs/sailfin/administration/src/main/sman/man1/deploy.1,v <-- deploy.1
        initial revision: 1.1
        done

        Show
        chinmayee_srivathsa added a comment - Created new sailfin-specific deploy man page. RCS file: /cvs/sailfin/administration/src/main/sman/cat1/deploy.1,v done Checking in deploy.1; /cvs/sailfin/administration/src/main/sman/cat1/deploy.1,v <-- deploy.1 initial revision: 1.1 done RCS file: /cvs/sailfin/administration/src/main/sman/man1/deploy.1,v done Checking in deploy.1; /cvs/sailfin/administration/src/main/sman/man1/deploy.1,v <-- deploy.1 initial revision: 1.1 done

          People

          • Assignee:
            chinmayee_srivathsa
            Reporter:
            erikvandervelden
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: