sailfin
  1. sailfin
  2. SAILFIN-948

[online docs] asadmin stop-node-agent -stopinstances=false

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0
    • Fix Version/s: milestone 1
    • Component/s: admin
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      948

      Description

      Should tell the NA to leave the SIs running. Maybe an open issue how NA can re-
      establish any contact to the SIs if started with already running SIs.

        Activity

        Hide
        km added a comment -

        This is a major change in NA design. So, I think, this is really a "feature" not
        an enhancement, mainly because NA was "designed" to take the instances down while
        it shuts down. Provision of a simple flag on stop-node-agent does not allow us
        make sweeping changes in the implementation.

        Again, I agree with the spirit of this request, but it has implementation costs
        that I am not sure of being able to fulfill in the short term. So, please let us
        know which release (time frame) you are looking at, to get a fix for this.

        Show
        km added a comment - This is a major change in NA design. So, I think, this is really a "feature" not an enhancement, mainly because NA was "designed" to take the instances down while it shuts down. Provision of a simple flag on stop-node-agent does not allow us make sweeping changes in the implementation. Again, I agree with the spirit of this request, but it has implementation costs that I am not sure of being able to fulfill in the short term. So, please let us know which release (time frame) you are looking at, to get a fix for this.
        Hide
        andbur added a comment -

        Ericsson will be using the "kill NA"-integration with SAF/AMF in our first
        release. This issue effects our future design so the time frame would be Q4
        2008.

        Show
        andbur added a comment - Ericsson will be using the "kill NA"-integration with SAF/AMF in our first release. This issue effects our future design so the time frame would be Q4 2008.
        Hide
        Yamini K B added a comment -

        Lowering the priority since it will not be fixed for 1.5

        Show
        Yamini K B added a comment - Lowering the priority since it will not be fixed for 1.5
        Hide
        srinik76 added a comment -

        Checked in the fix.

        Added an option stopinstances to stop-node-agent to control the stop of
        instances which is by default true

        Issue number: 948
        Obtained from:
        Submitted by:
        Reviewed by: Nandini

        Tests Run: Glassfish Cluster QL

        Modified Files:

        admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/InstancesManager.java
        admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/pe/PEDomainsManager.java
        admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/pe/PEInstancesManager.java
        admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/BaseNodeAgent.java
        admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/NodeAgent.java
        admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/NodeAgentMain.java
        admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/ProcessInstanceInternal.java
        admin-ee/servermgmt/src/java/com/sun/enterprise/ee/admin/servermgmt/AgentManager.java
        admin-ee/servermgmt/src/java/com/sun/enterprise/ee/admin/servermgmt/EEInstancesManager.java
        admin-ee/servermgmt/src/java/com/sun/enterprise/ee/admin/servermgmt/ASShutdown.java
        admin-core/util/src/java/com/sun/enterprise/admin/util/IAdminConstants.java
        appserv-core/src/java/com/sun/enterprise/admin/event/ShutdownEvent.java
        admin-cli-ee/commands/src/java/com/sun/enterprise/ee/cli/commands/CLIDescriptor.xml
        admin-cli-ee/commands/src/java/com/sun/enterprise/ee/cli/commands/BaseNodeAgentCommand.java
        admin-cli-ee/commands/src/java/com/sun/enterprise/ee/cli/commands/StopNodeAgentCommand.java
        appserv-core/src/java/com/sun/enterprise/server/PEMain.java

        ===================================================================
        File: InstancesManager.java Status: Up-to-date

        Working revision: 1.9.6.1
        Repository revision: 1.9.6.1
        /cvs/glassfish/admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/InstancesManager.java,v
        Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.9.6)
        Sticky Date: (none)
        Sticky Options: (none)

        ===================================================================
        File: PEDomainsManager.java Status: Up-to-date

        Working revision: 1.22.2.3
        Repository revision: 1.22.2.3
        /cvs/glassfish/admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/pe/PEDomainsManager.java,v
        Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.22.2)
        Sticky Date: (none)
        Sticky Options: (none)

        ===================================================================
        File: PEInstancesManager.java Status: Up-to-date

        Working revision: 1.22.2.2
        Repository revision: 1.22.2.2
        /cvs/glassfish/admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/pe/PEInstancesManager.java,v
        Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.22.2)
        Sticky Date: (none)
        Sticky Options: (none)

        ===================================================================
        File: BaseNodeAgent.java Status: Up-to-date

        Working revision: 1.4.2.4
        Repository revision: 1.4.2.4
        /cvs/glassfish/admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/BaseNodeAgent.java,v
        Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.4.2)
        Sticky Date: (none)
        Sticky Options: (none)

        ===================================================================
        File: NodeAgent.java Status: Up-to-date

        Working revision: 1.28.2.6
        Repository revision: 1.28.2.6
        /cvs/glassfish/admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/NodeAgent.java,v
        Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.28.2)
        Sticky Date: (none)
        Sticky Options: (none)

        ===================================================================
        File: NodeAgentMain.java Status: Up-to-date

        Working revision: 1.12.2.5
        Repository revision: 1.12.2.5
        /cvs/glassfish/admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/NodeAgentMain.java,v
        Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.12.2)
        Sticky Date: (none)
        Sticky Options: (none)

        ===================================================================
        File: ProcessInstanceInternal.java Status: Up-to-date

        Working revision: 1.7.2.2
        Repository revision: 1.7.2.2
        /cvs/glassfish/admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/ProcessInstanceInternal.java,v
        Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.7.2)
        Sticky Date: (none)
        Sticky Options: (none)

        ===================================================================
        File: AgentManager.java Status: Up-to-date

        Working revision: 1.14.2.3
        Repository revision: 1.14.2.3
        /cvs/glassfish/admin-ee/servermgmt/src/java/com/sun/enterprise/ee/admin/servermgmt/AgentManager.java,v
        Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.14.2)
        Sticky Date: (none)
        Sticky Options: (none)

        ===================================================================
        File: EEInstancesManager.java Status: Up-to-date

        Working revision: 1.14.6.1
        Repository revision: 1.14.6.1
        /cvs/glassfish/admin-ee/servermgmt/src/java/com/sun/enterprise/ee/admin/servermgmt/EEInstancesManager.java,v
        Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.14.6)
        Sticky Date: (none)
        Sticky Options: (none)

        ===================================================================
        File: ASShutdown.java Status: Up-to-date

        Working revision: 1.1.8.1
        Repository revision: 1.1.8.1
        /cvs/glassfish/admin-ee/servermgmt/src/java/com/sun/enterprise/ee/admin/servermgmt/ASShutdown.java,v
        Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.1.8)
        Sticky Date: (none)
        Sticky Options: (none)

        ===================================================================
        File: IAdminConstants.java Status: Up-to-date

        Working revision: 1.6.6.3
        Repository revision: 1.6.6.3
        /cvs/glassfish/admin-core/util/src/java/com/sun/enterprise/admin/util/IAdminConstants.java,v
        Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.6.6)
        Sticky Date: (none)
        Sticky Options: (none)

        ===================================================================
        File: ShutdownEvent.java Status: Up-to-date

        Working revision: 1.4.6.1
        Repository revision: 1.4.6.1
        /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/event/ShutdownEvent.java,v
        Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.4.6)
        Sticky Date: (none)
        Sticky Options: (none)

        ===================================================================
        File: CLIDescriptor.xml Status: Up-to-date

        Working revision: 1.24.2.3
        Repository revision: 1.24.2.3
        /cvs/glassfish/admin-cli-ee/commands/src/java/com/sun/enterprise/ee/cli/commands/CLIDescriptor.xml,v
        Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.24.2)
        Sticky Date: (none)
        Sticky Options: (none)

        ===================================================================
        File: BaseNodeAgentCommand.java Status: Up-to-date

        Working revision: 1.5.6.3
        Repository revision: 1.5.6.3
        /cvs/glassfish/admin-cli-ee/commands/src/java/com/sun/enterprise/ee/cli/commands/BaseNodeAgentCommand.java,v
        Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.5.6)
        Sticky Date: (none)
        Sticky Options: (none)

        ===================================================================
        File: StopNodeAgentCommand.java Status: Up-to-date

        Working revision: 1.5.6.1
        Repository revision: 1.5.6.1
        /cvs/glassfish/admin-cli-ee/commands/src/java/com/sun/enterprise/ee/cli/commands/StopNodeAgentCommand.java,v
        Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.5.6)
        Sticky Date: (none)
        Sticky Options: (none)

        ===================================================================
        File: PEMain.java Status: Up-to-date

        Working revision: 1.21.6.2
        Repository revision: 1.21.6.2
        /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/server/PEMain.java,v
        Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.21.6)
        Sticky Date: (none)
        Sticky Options: (none)

        Show
        srinik76 added a comment - Checked in the fix. Added an option stopinstances to stop-node-agent to control the stop of instances which is by default true Issue number: 948 Obtained from: Submitted by: Reviewed by: Nandini Tests Run: Glassfish Cluster QL Modified Files: admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/InstancesManager.java admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/pe/PEDomainsManager.java admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/pe/PEInstancesManager.java admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/BaseNodeAgent.java admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/NodeAgent.java admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/NodeAgentMain.java admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/ProcessInstanceInternal.java admin-ee/servermgmt/src/java/com/sun/enterprise/ee/admin/servermgmt/AgentManager.java admin-ee/servermgmt/src/java/com/sun/enterprise/ee/admin/servermgmt/EEInstancesManager.java admin-ee/servermgmt/src/java/com/sun/enterprise/ee/admin/servermgmt/ASShutdown.java admin-core/util/src/java/com/sun/enterprise/admin/util/IAdminConstants.java appserv-core/src/java/com/sun/enterprise/admin/event/ShutdownEvent.java admin-cli-ee/commands/src/java/com/sun/enterprise/ee/cli/commands/CLIDescriptor.xml admin-cli-ee/commands/src/java/com/sun/enterprise/ee/cli/commands/BaseNodeAgentCommand.java admin-cli-ee/commands/src/java/com/sun/enterprise/ee/cli/commands/StopNodeAgentCommand.java appserv-core/src/java/com/sun/enterprise/server/PEMain.java =================================================================== File: InstancesManager.java Status: Up-to-date Working revision: 1.9.6.1 Repository revision: 1.9.6.1 /cvs/glassfish/admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/InstancesManager.java,v Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.9.6) Sticky Date: (none) Sticky Options: (none) =================================================================== File: PEDomainsManager.java Status: Up-to-date Working revision: 1.22.2.3 Repository revision: 1.22.2.3 /cvs/glassfish/admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/pe/PEDomainsManager.java,v Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.22.2) Sticky Date: (none) Sticky Options: (none) =================================================================== File: PEInstancesManager.java Status: Up-to-date Working revision: 1.22.2.2 Repository revision: 1.22.2.2 /cvs/glassfish/admin/servermgmt/src/java/com/sun/enterprise/admin/servermgmt/pe/PEInstancesManager.java,v Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.22.2) Sticky Date: (none) Sticky Options: (none) =================================================================== File: BaseNodeAgent.java Status: Up-to-date Working revision: 1.4.2.4 Repository revision: 1.4.2.4 /cvs/glassfish/admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/BaseNodeAgent.java,v Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.4.2) Sticky Date: (none) Sticky Options: (none) =================================================================== File: NodeAgent.java Status: Up-to-date Working revision: 1.28.2.6 Repository revision: 1.28.2.6 /cvs/glassfish/admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/NodeAgent.java,v Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.28.2) Sticky Date: (none) Sticky Options: (none) =================================================================== File: NodeAgentMain.java Status: Up-to-date Working revision: 1.12.2.5 Repository revision: 1.12.2.5 /cvs/glassfish/admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/NodeAgentMain.java,v Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.12.2) Sticky Date: (none) Sticky Options: (none) =================================================================== File: ProcessInstanceInternal.java Status: Up-to-date Working revision: 1.7.2.2 Repository revision: 1.7.2.2 /cvs/glassfish/admin-ee/nodeagent/src/java/com/sun/enterprise/ee/nodeagent/ProcessInstanceInternal.java,v Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.7.2) Sticky Date: (none) Sticky Options: (none) =================================================================== File: AgentManager.java Status: Up-to-date Working revision: 1.14.2.3 Repository revision: 1.14.2.3 /cvs/glassfish/admin-ee/servermgmt/src/java/com/sun/enterprise/ee/admin/servermgmt/AgentManager.java,v Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.14.2) Sticky Date: (none) Sticky Options: (none) =================================================================== File: EEInstancesManager.java Status: Up-to-date Working revision: 1.14.6.1 Repository revision: 1.14.6.1 /cvs/glassfish/admin-ee/servermgmt/src/java/com/sun/enterprise/ee/admin/servermgmt/EEInstancesManager.java,v Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.14.6) Sticky Date: (none) Sticky Options: (none) =================================================================== File: ASShutdown.java Status: Up-to-date Working revision: 1.1.8.1 Repository revision: 1.1.8.1 /cvs/glassfish/admin-ee/servermgmt/src/java/com/sun/enterprise/ee/admin/servermgmt/ASShutdown.java,v Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.1.8) Sticky Date: (none) Sticky Options: (none) =================================================================== File: IAdminConstants.java Status: Up-to-date Working revision: 1.6.6.3 Repository revision: 1.6.6.3 /cvs/glassfish/admin-core/util/src/java/com/sun/enterprise/admin/util/IAdminConstants.java,v Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.6.6) Sticky Date: (none) Sticky Options: (none) =================================================================== File: ShutdownEvent.java Status: Up-to-date Working revision: 1.4.6.1 Repository revision: 1.4.6.1 /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/admin/event/ShutdownEvent.java,v Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.4.6) Sticky Date: (none) Sticky Options: (none) =================================================================== File: CLIDescriptor.xml Status: Up-to-date Working revision: 1.24.2.3 Repository revision: 1.24.2.3 /cvs/glassfish/admin-cli-ee/commands/src/java/com/sun/enterprise/ee/cli/commands/CLIDescriptor.xml,v Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.24.2) Sticky Date: (none) Sticky Options: (none) =================================================================== File: BaseNodeAgentCommand.java Status: Up-to-date Working revision: 1.5.6.3 Repository revision: 1.5.6.3 /cvs/glassfish/admin-cli-ee/commands/src/java/com/sun/enterprise/ee/cli/commands/BaseNodeAgentCommand.java,v Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.5.6) Sticky Date: (none) Sticky Options: (none) =================================================================== File: StopNodeAgentCommand.java Status: Up-to-date Working revision: 1.5.6.1 Repository revision: 1.5.6.1 /cvs/glassfish/admin-cli-ee/commands/src/java/com/sun/enterprise/ee/cli/commands/StopNodeAgentCommand.java,v Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.5.6) Sticky Date: (none) Sticky Options: (none) =================================================================== File: PEMain.java Status: Up-to-date Working revision: 1.21.6.2 Repository revision: 1.21.6.2 /cvs/glassfish/appserv-core/src/java/com/sun/enterprise/server/PEMain.java,v Sticky Tag: SJSAS91_FCS_BRANCH (branch: 1.21.6) Sticky Date: (none) Sticky Options: (none)
        Hide
        srinik76 added a comment -

        This needs to be documented. Assigning to docs team

        Show
        srinik76 added a comment - This needs to be documented. Assigning to docs team
        Hide
        srinik76 added a comment -

        New option has been added to stop-node-agent, stopinstances. The default value
        is true. If stop-node-agent is invoked with stopinstances as false, then the
        instances will not be stopped by node agent.

        -bash-3.00# ./asadmin stop-node-agent --option
        Usage: stop-node-agent [--terse=false] [--echo=false] [--stopinstances=true]
        [--interactive=true] [--secure=true] [--agentdir nodeagent_path] [nodeagent_name]

        Show
        srinik76 added a comment - New option has been added to stop-node-agent, stopinstances. The default value is true. If stop-node-agent is invoked with stopinstances as false, then the instances will not be stopped by node agent. -bash-3.00# ./asadmin stop-node-agent --option Usage: stop-node-agent [--terse=false] [--echo=false] [--stopinstances=true] [--interactive=true] [--secure=true] [--agentdir nodeagent_path] [nodeagent_name]
        Hide
        srinik76 added a comment -

        This needs to be documented in glassfish also.

        Show
        srinik76 added a comment - This needs to be documented in glassfish also.
        Hide
        chinmayee_srivathsa added a comment -

        Checked in the updated man page to SailFin build.

        For GlassFish, will fix this issue in the Reference manual.

        Marking as [online docs].

        Show
        chinmayee_srivathsa added a comment - Checked in the updated man page to SailFin build. For GlassFish, will fix this issue in the Reference manual. Marking as [online docs] .
        Hide
        chinmayee_srivathsa added a comment -

        Fixed in the Reference Manual for GlassFish and SailFin

        Show
        chinmayee_srivathsa added a comment - Fixed in the Reference Manual for GlassFish and SailFin

          People

          • Assignee:
            chinmayee_srivathsa
            Reporter:
            andbur
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: