servlet-spec
  1. servlet-spec
  2. SERVLET_SPEC-4

Clarification on javadoc and spec examples on AsyncContext#dispatch()

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      In javadoc of javax.servlet.AsyncContext#dispatch(), we have
      ...
      getRequestDispatcher("/url/B").forward(request,response);
      ...
      getRequestDispatcher("/url/B").forward(request,response);

      It should be
      request.getRequestDispatcher("/url/B").forward(request,response);
      or
      servletContext.getRequestDispatcher("/url/B").forward(request,response);

      In p.15 of spec pdf file, there is a similar issue.
      Also, one may like to add "//" for comment and additional information from javadoc.

        Activity

        Shing Wai Chan created issue -
        Hide
        Shing Wai Chan added a comment -

        In p14 of Servlet 3.0 spec, we have
        "public void addListener(asyncListener, req, res) - Registers the
        listener for notifications of time out, error and complete with the most ..."

        "public void addListener(asyncListener) - Registers the given listener
        for notifications of time out, error and complete with the most recent ..."

        It should also the onStartAsync here.

        Also, in p14, we have "buy may be used in order to release any resources".
        The "buy" should be "but" here.

        Show
        Shing Wai Chan added a comment - In p14 of Servlet 3.0 spec, we have "public void addListener(asyncListener, req, res) - Registers the listener for notifications of time out, error and complete with the most ..." "public void addListener(asyncListener) - Registers the given listener for notifications of time out, error and complete with the most recent ..." It should also the onStartAsync here. Also, in p14, we have "buy may be used in order to release any resources". The "buy" should be "but" here.
        Rajiv Mordani made changes -
        Field Original Value New Value
        Assignee Shing Wai Chan [ swchan2 ]
        Shing Wai Chan made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Shing Wai Chan added a comment -

        The javadoc is fixed:
        Sending javax.servlet/src/main/java/javax/servlet/AsyncContext.java
        Sending javax.servlet/src/main/java/javax/servlet/ServletRequest.java
        Transmitting file data ..
        Committed revision 51595.

        Show
        Shing Wai Chan added a comment - The javadoc is fixed: Sending javax.servlet/src/main/java/javax/servlet/AsyncContext.java Sending javax.servlet/src/main/java/javax/servlet/ServletRequest.java Transmitting file data .. Committed revision 51595.
        Hide
        Shing Wai Chan added a comment -

        Sending servletobjects.fm
        Transmitting file data .
        Committed revision 3.

        Show
        Shing Wai Chan added a comment - Sending servletobjects.fm Transmitting file data . Committed revision 3.
        Shing Wai Chan made changes -
        Status In Progress [ 3 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Shing Wai Chan
            Reporter:
            Shing Wai Chan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: