shoal
  1. shoal
  2. SHOAL-115

MultiCastReceiverThread is not clearing buffer in DatagramPacket

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: current
    • Fix Version/s: current
    • Component/s: GMS
    • Labels:
      None

      Description

      In the thread's run method, the same byte buffer is being used for each DatagramPacket created. So the data returned from receive method can contain extra text, which throws of the set of host strings. So hosts will show up more than once in the output of the validate multicast tool.

      Simple fix is just to create a new byte array for each packet (or clear the old one). Without this fix, the tool still gives accurate results – it can just include extra copies of previous entries. I have a GF issue filed for integration, and this one for the actual fix.

        Issue Links

          Activity

          Hide
          Bobby Bissett added a comment -

          Fixed in revision 1544.

          Show
          Bobby Bissett added a comment - Fixed in revision 1544.

            People

            • Assignee:
              Bobby Bissett
              Reporter:
              Bobby Bissett
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: