shoal
  1. shoal
  2. SHOAL-45

MessageWindow NullPointerException handling GMSMessage

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: current
    • Fix Version/s: milestone 1
    • Component/s: GMS
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      45
    • Status Whiteboard:
      Hide

      shoal-shark-na

      Show
      shoal-shark-na

      Description

      GroupHandle#sendMessage(String targetComponentName, byte[] message) contract
      states that "Specifying a null component name would result in the message being
      delivered to all registered components" on forwarding a message such as

      sendMessage(null, "Example message".getBytes());

      a NullPointerException is thrown from MessageWindow#handleGMSMessage where

      if(gMsg.getComponentName().equals(GMSConstants.shutdownType.GROUP_SHUTDOWN.toString()))

      gMsg.getComponentName() is null.

      A fix is:

      if (gMsg.getComponentName()!=null &&
      gMsg.getComponentName().equals(GMSConstants.shutdownType.GROUP_SHUTDOWN.toString()))

        Activity

        Hide
        shreedhar_ganapathy added a comment -

        Thanks for bringing this to our attention. We will add a test case for this
        situation.
        Reassigning to Sheetal for fix.

        Show
        shreedhar_ganapathy added a comment - Thanks for bringing this to our attention. We will add a test case for this situation. Reassigning to Sheetal for fix.
        Hide
        sheetalv added a comment -

        not important for Sailfin 0.5

        Show
        sheetalv added a comment - not important for Sailfin 0.5
        Hide
        sheetalv added a comment -
        Show
        sheetalv added a comment - Fixed in Shoal trunk. https://shoal.dev.java.net/servlets/ReadMsg?list=cvs&msgNo=646

          People

          • Assignee:
            sheetalv
            Reporter:
            garyfeltham
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: