Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 3.2
    • Fix Version/s: RC
    • Component/s: base package
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      170

      Description

      Hi,
      first I would like to say that I like a lot this Swing theme. Keep up the good work.
      I have found a bug and I have a snippet of code to demonstrate it for you :

      import java.awt.BorderLayout;
      import java.awt.Color;
      import java.awt.Component;
      import java.awt.Font;
      import java.awt.event.ItemEvent;
      import java.awt.event.ItemListener;
      import java.awt.event.MouseEvent;
      import java.util.EventObject;
      import java.util.Vector;

      import javax.swing.AbstractCellEditor;
      import javax.swing.JCheckBox;
      import javax.swing.JFrame;
      import javax.swing.JScrollPane;
      import javax.swing.JTree;
      import javax.swing.UIManager;
      import javax.swing.UnsupportedLookAndFeelException;
      import javax.swing.event.ChangeEvent;
      import javax.swing.tree.DefaultMutableTreeNode;
      import javax.swing.tree.DefaultTreeCellRenderer;
      import javax.swing.tree.TreeCellEditor;
      import javax.swing.tree.TreeCellRenderer;
      import javax.swing.tree.TreePath;

      public class CheckBoxNodeTreeSample {
      public static void main(String args[]) {
      JFrame frame = new JFrame("CheckBox Tree");

      setLookAndFeel();

      CheckBoxNode accessibilityOptions[] =

      { new CheckBoxNode( "Move system caret with focus/selection changes", false), new CheckBoxNode("Always expand alt text for images", true) }

      ;
      CheckBoxNode browsingOptions[] =

      { new CheckBoxNode("Notify when downloads complete", true), new CheckBoxNode("Disable script debugging", true), new CheckBoxNode("Use AutoComplete", true), new CheckBoxNode("Browse in a new process", false) }

      ;
      Vector accessVector = new NamedVector("Accessibility",
      accessibilityOptions);
      Vector browseVector = new NamedVector("Browsing", browsingOptions);
      Object rootNodes[] =

      { accessVector, browseVector }

      ;
      Vector rootVector = new NamedVector("Root", rootNodes);
      JTree tree = new JTree(rootVector);

      CheckBoxNodeRenderer renderer = new CheckBoxNodeRenderer();
      tree.setCellRenderer(renderer);

      tree.setCellEditor(new CheckBoxNodeEditor(tree));
      tree.setEditable(true);

      JScrollPane scrollPane = new JScrollPane(tree);
      frame.getContentPane().add(scrollPane, BorderLayout.CENTER);
      frame.setSize(300, 150);
      frame.setVisible(true);
      }

      private static void setLookAndFeel()
      {
      try

      { UIManager.setLookAndFeel("org.jvnet.substance.SubstanceLookAndFeel"); }

      catch ( ClassNotFoundException e )

      { e.printStackTrace(); }
      catch ( InstantiationException e )
      { e.printStackTrace(); }

      catch ( IllegalAccessException e )

      { e.printStackTrace(); }
      catch ( UnsupportedLookAndFeelException e )
      { e.printStackTrace(); }

      }
      }

      class CheckBoxNodeRenderer implements TreeCellRenderer {
      private JCheckBox leafRenderer = new JCheckBox();

      private DefaultTreeCellRenderer nonLeafRenderer = new DefaultTreeCellRenderer();

      Color selectionBorderColor, selectionForeground, selectionBackground,
      textForeground, textBackground;

      protected JCheckBox getLeafRenderer()

      { return leafRenderer; }

      public CheckBoxNodeRenderer() {
      Font fontValue;
      fontValue = UIManager.getFont("Tree.font");
      if (fontValue != null)

      { leafRenderer.setFont(fontValue); }

      Boolean booleanValue = (Boolean) UIManager
      .get("Tree.drawsFocusBorderAroundIcon");
      leafRenderer.setFocusPainted((booleanValue != null)
      && (booleanValue.booleanValue()));

      selectionBorderColor = UIManager.getColor("Tree.selectionBorderColor");
      selectionForeground = UIManager.getColor("Tree.selectionForeground");
      selectionBackground = UIManager.getColor("Tree.selectionBackground");
      textForeground = UIManager.getColor("Tree.textForeground");
      textBackground = UIManager.getColor("Tree.textBackground");
      }

      public Component getTreeCellRendererComponent(JTree tree, Object value,
      boolean selected, boolean expanded, boolean leaf, int row,
      boolean hasFocus) {

      Component returnValue;
      if (leaf) {

      String stringValue = tree.convertValueToText(value, selected,
      expanded, leaf, row, false);
      leafRenderer.setText(stringValue);
      leafRenderer.setSelected(false);

      leafRenderer.setEnabled(tree.isEnabled());

      if (selected)

      { leafRenderer.setForeground(selectionForeground); leafRenderer.setBackground(selectionBackground); }

      else

      { leafRenderer.setForeground(textForeground); leafRenderer.setBackground(textBackground); }

      if ((value != null) && (value instanceof DefaultMutableTreeNode)) {
      Object userObject = ((DefaultMutableTreeNode) value)
      .getUserObject();
      if (userObject instanceof CheckBoxNode)

      { CheckBoxNode node = (CheckBoxNode) userObject; leafRenderer.setText(node.getText()); leafRenderer.setSelected(node.isSelected()); }

      }
      returnValue = leafRenderer;
      } else

      { returnValue = nonLeafRenderer.getTreeCellRendererComponent(tree, value, selected, expanded, leaf, row, hasFocus); }

      return returnValue;
      }
      }

      class CheckBoxNodeEditor extends AbstractCellEditor implements TreeCellEditor {

      CheckBoxNodeRenderer renderer = new CheckBoxNodeRenderer();

      ChangeEvent changeEvent = null;

      JTree tree;

      public CheckBoxNodeEditor(JTree tree)

      { this.tree = tree; }

      public Object getCellEditorValue()

      { JCheckBox checkbox = renderer.getLeafRenderer(); CheckBoxNode checkBoxNode = new CheckBoxNode(checkbox.getText(), checkbox.isSelected()); return checkBoxNode; }

      public boolean isCellEditable(EventObject event) {
      boolean returnValue = false;
      if (event instanceof MouseEvent) {
      MouseEvent mouseEvent = (MouseEvent) event;
      TreePath path = tree.getPathForLocation(mouseEvent.getX(),
      mouseEvent.getY());
      if (path != null) {
      Object node = path.getLastPathComponent();
      if ((node != null) && (node instanceof DefaultMutableTreeNode))

      { DefaultMutableTreeNode treeNode = (DefaultMutableTreeNode) node; Object userObject = treeNode.getUserObject(); returnValue = ((treeNode.isLeaf()) && (userObject instanceof CheckBoxNode)); }

      }
      }
      return returnValue;
      }

      public Component getTreeCellEditorComponent(JTree tree, Object value,
      boolean selected, boolean expanded, boolean leaf, int row) {

      Component editor = renderer.getTreeCellRendererComponent(tree, value,
      true, expanded, leaf, row, true);

      // editor always selected / focused
      ItemListener itemListener = new ItemListener() {
      public void itemStateChanged(ItemEvent itemEvent) {
      if (stopCellEditing())

      { fireEditingStopped(); }

      }
      };
      if (editor instanceof JCheckBox)

      { ((JCheckBox) editor).addItemListener(itemListener); }

      return editor;
      }
      }

      class CheckBoxNode {
      String text;

      boolean selected;

      public CheckBoxNode(String text, boolean selected)

      { this.text = text; this.selected = selected; }

      public boolean isSelected()

      { return selected; }

      public void setSelected(boolean newValue)

      { selected = newValue; }

      public String getText()

      { return text; }

      public void setText(String newValue)

      { text = newValue; }

      public String toString()

      { return getClass().getName() + "[" + text + "/" + selected + "]"; }

      }

      class NamedVector extends Vector {
      String name;

      public NamedVector(String name)

      { this.name = name; }

      public NamedVector(String name, Object elements[]) {
      this.name = name;
      for (int i = 0, n = elements.length; i < n; i++)

      { add(elements[i]); }

      }

      public String toString()

      { return "[" + name + "]"; }

      }

      Run this code and try checking the boxes.
      If you check only 1 box, the others get checked also and the whole thing
      behaves strangely. If you remove your theme, the code runs perfectly.

      Don't hesitate if you have any other questions
      Thx
      Patrick

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            kirillcool
            Reporter:
            dbjav
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: