swingx
  1. swingx
  2. SWINGX-1002

Merge ColorBlendHighlighter into ColorHighlighter

    Details

    • Issuezilla Id:
      1,002

      Description

      I think that the AlphaBlendHighlighter has a place in the standard set. See
      the thread for comments on how that highlighter might affect ColorHighlighter.

      Karl

        Issue Links

          Activity

          Hide
          Karl Schaefer added a comment -

          Making post 1.0, unless you want to squeeze it in, Jeanette.

          Karl

          Show
          Karl Schaefer added a comment - Making post 1.0, unless you want to squeeze it in, Jeanette. Karl
          Hide
          kleopatra added a comment -

          Karl,

          if you want to add it now - just take the issue and go ahead (but don't forget
          to add some tests as well

          Curious: why coding the blend again - with all our different ColorUtils, isn't
          there anything suitable in there?

          Cheers
          Jeanette

          Show
          kleopatra added a comment - Karl, if you want to add it now - just take the issue and go ahead (but don't forget to add some tests as well Curious: why coding the blend again - with all our different ColorUtils, isn't there anything suitable in there? Cheers Jeanette
          Hide
          Karl Schaefer added a comment -

          None of our color utility classes will handle producing a blended color.
          Perhaps, we should add such a method and use it in the Highlighter.

          Karl

          Show
          Karl Schaefer added a comment - None of our color utility classes will handle producing a blended color. Perhaps, we should add such a method and use it in the Highlighter. Karl
          Hide
          kleopatra added a comment -

          think so - after all, the ColorUtils (the one or other <g>) is meant as the
          place for doing such stuff.

          CU
          Jeanette

          Show
          kleopatra added a comment - think so - after all, the ColorUtils (the one or other <g>) is meant as the place for doing such stuff. CU Jeanette
          Hide
          kleopatra added a comment -

          Karl, what's the status here? Would love to give the issue over to you (as you sure have
          more insight than I do

          Thanks
          Jeanette

          Show
          kleopatra added a comment - Karl, what's the status here? Would love to give the issue over to you (as you sure have more insight than I do Thanks Jeanette
          Hide
          Karl Schaefer added a comment -

          Reviewing this code, I don't think we need a separate highlighter for this. I
          just checked (filed and fixed Issue 1315) to ensure that the blending function
          will result in correct values. I suggest that we add the blending to the
          current ColorHighlighter. People using fully-opaque colors will see no change.

          Show
          Karl Schaefer added a comment - Reviewing this code, I don't think we need a separate highlighter for this. I just checked (filed and fixed Issue 1315) to ensure that the blending function will result in correct values. I suggest that we add the blending to the current ColorHighlighter. People using fully-opaque colors will see no change.
          Hide
          Karl Schaefer added a comment -

          I have made the update locally, run the unit tests and performed the visual
          checks. All appears well. Want to gets Jeanette's sign-off on changing our
          most fundamental highlighter before committing.

          Show
          Karl Schaefer added a comment - I have made the update locally, run the unit tests and performed the visual checks. All appears well. Want to gets Jeanette's sign-off on changing our most fundamental highlighter before committing.
          Hide
          kleopatra added a comment -

          Hmm ... what about those using not-fully opaque colors? Or would that be pathological,
          anyway? If they see a change, maybe add a toggle to let them decide if they want the
          blend and have that property false by default? We had lots of heated debates at the very
          beginning, which ended in the current state. Would hate to break anything out there.

          Cheers
          Jeanette

          Show
          kleopatra added a comment - Hmm ... what about those using not-fully opaque colors? Or would that be pathological, anyway? If they see a change, maybe add a toggle to let them decide if they want the blend and have that property false by default? We had lots of heated debates at the very beginning, which ended in the current state. Would hate to break anything out there. Cheers Jeanette
          Hide
          Karl Schaefer added a comment -

          Issue 1002: Merged the color blending code into the ColorHighlighter. Added a
          legacy mode to the highlighter to use the old non-blending behavior.

          src/java/org/jdesktop/swingx/decorator/ColorHighlighter.java

          Committed revision 3700.

          Show
          Karl Schaefer added a comment - Issue 1002: Merged the color blending code into the ColorHighlighter. Added a legacy mode to the highlighter to use the old non-blending behavior. src/java/org/jdesktop/swingx/decorator/ColorHighlighter.java Committed revision 3700.

            People

            • Assignee:
              Karl Schaefer
              Reporter:
              Karl Schaefer
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: