Issue Details (XML | Word | Printable)

Key: SWINGX-1309
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: kleopatra
Reporter: uvoigt
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
swingx

WrappingProvider needs a configuration if the IconValue should be highlighted

Created: 26/Apr/10 03:03 AM   Updated: 28/Jan/11 12:54 PM   Resolved: 09/Nov/10 07:20 AM
Component/s: Renderer
Affects Version/s: 1.6.1
Fix Version/s: 1.6.3

Time Tracking:
Not Specified

Environment:

Issuezilla Id: 1,309
Tags:
Participants: kleopatra and uvoigt


 Description  « Hide

The RendererVisualCheck shows a problem with the WrappingProvider. The icon
component of the WrappingProvider is not highlighted. e.g. this can make
problems if the icon is not opaque and the background is highlighted.

Test-Code for RendererVisualCheck:
public void interactiveIconTextAlignment() { ListModel files = createFileListModel(); JXList list = new JXList(files); ComponentProvider<?> text = new LabelProvider(StringValues.FILE_NAME, JLabel.TRAILING); WrappingProvider wrapper = new WrappingProvider(IconValues.FILE_ICON, text, true); list.setCellRenderer(new DefaultListRenderer(wrapper)); list.addHighlighter(HighlighterFactory.createAlternateStriping()); showWithScrollingInFrame(list, "alignment in wrappingProvider"); }



kleopatra added a comment - 26/Apr/10 03:45 AM

updated RendererVisualCheck to expose the issue


kleopatra added a comment - 04/Nov/10 07:34 AM
  • added property extendsComponentOpacity to WrappingIconPanel
  • updated visual test method to allow toggle of the property

Committed as of revision #3880. Could you please check if that's what you expect? If so,
I'll consider to pull up into the WrappingProvider.

Thanks


kleopatra added a comment - 05/Nov/10 02:40 AM

added convenience method to WrappingProvider


uvoigt added a comment - 05/Nov/10 06:03 AM

The testcase looks good now! Thanks.
I am not able to integrate that to my application at the moment because Hudson
is down at the moment and I am not able to build a new swingx.jar from source.
So I have to wait for the next release to give a qualified feedback.


kleopatra added a comment - 05/Nov/10 09:01 AM

hmm ... may I ask why you can't build the jar from the source? Maybe I can help somehow?

Hudson might be down a while ... not sure if Jan can fix it this weekend.

Thanks
Jeanette


uvoigt added a comment - 09/Nov/10 07:20 AM

I have no maven installed. But Hudson is back again so I could test it now.

The fix is perfect. Now I can use the IconHighlighters to set left aligned icons
as described in the thread
http://forums.java.net/jive/thread.jspa?threadID=79226&tstart=0.

Thanks!