swingx
  1. swingx
  2. SWINGX-1309

WrappingProvider needs a configuration if the IconValue should be highlighted

    Details

    • Issuezilla Id:
      1,309

      Description

      The RendererVisualCheck shows a problem with the WrappingProvider. The icon
      component of the WrappingProvider is not highlighted. e.g. this can make
      problems if the icon is not opaque and the background is highlighted.

      Test-Code for RendererVisualCheck:
      public void interactiveIconTextAlignment()

      { ListModel files = createFileListModel(); JXList list = new JXList(files); ComponentProvider<?> text = new LabelProvider(StringValues.FILE_NAME, JLabel.TRAILING); WrappingProvider wrapper = new WrappingProvider(IconValues.FILE_ICON, text, true); list.setCellRenderer(new DefaultListRenderer(wrapper)); list.addHighlighter(HighlighterFactory.createAlternateStriping()); showWithScrollingInFrame(list, "alignment in wrappingProvider"); }

        Activity

        Hide
        kleopatra added a comment -

        updated RendererVisualCheck to expose the issue

        Show
        kleopatra added a comment - updated RendererVisualCheck to expose the issue
        Hide
        kleopatra added a comment -
        • added property extendsComponentOpacity to WrappingIconPanel
        • updated visual test method to allow toggle of the property

        Committed as of revision #3880. Could you please check if that's what you expect? If so,
        I'll consider to pull up into the WrappingProvider.

        Thanks

        Show
        kleopatra added a comment - added property extendsComponentOpacity to WrappingIconPanel updated visual test method to allow toggle of the property Committed as of revision #3880. Could you please check if that's what you expect? If so, I'll consider to pull up into the WrappingProvider. Thanks
        Hide
        kleopatra added a comment -

        added convenience method to WrappingProvider

        Show
        kleopatra added a comment - added convenience method to WrappingProvider
        Hide
        uvoigt added a comment -

        The testcase looks good now! Thanks.
        I am not able to integrate that to my application at the moment because Hudson
        is down at the moment and I am not able to build a new swingx.jar from source.
        So I have to wait for the next release to give a qualified feedback.

        Show
        uvoigt added a comment - The testcase looks good now! Thanks. I am not able to integrate that to my application at the moment because Hudson is down at the moment and I am not able to build a new swingx.jar from source. So I have to wait for the next release to give a qualified feedback.
        Hide
        kleopatra added a comment -

        hmm ... may I ask why you can't build the jar from the source? Maybe I can help somehow?

        Hudson might be down a while ... not sure if Jan can fix it this weekend.

        Thanks
        Jeanette

        Show
        kleopatra added a comment - hmm ... may I ask why you can't build the jar from the source? Maybe I can help somehow? Hudson might be down a while ... not sure if Jan can fix it this weekend. Thanks Jeanette
        Hide
        uvoigt added a comment -

        I have no maven installed. But Hudson is back again so I could test it now.

        The fix is perfect. Now I can use the IconHighlighters to set left aligned icons
        as described in the thread
        http://forums.java.net/jive/thread.jspa?threadID=79226&tstart=0.

        Thanks!

        Show
        uvoigt added a comment - I have no maven installed. But Hudson is back again so I could test it now. The fix is perfect. Now I can use the IconHighlighters to set left aligned icons as described in the thread http://forums.java.net/jive/thread.jspa?threadID=79226&tstart=0 . Thanks!

          People

          • Assignee:
            kleopatra
            Reporter:
            uvoigt
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: