Issue Details (XML | Word | Printable)

Key: SWINGX-1311
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: kleopatra
Reporter: kleopatra
Votes: 0
Watchers: 0

If you were logged in you would be able to see more operations.

IconHighlighter: add setting icon in WrappingProvider

Created: 26/Apr/10 08:15 AM   Updated: 28/Jan/11 12:54 PM   Resolved: 05/Nov/10 03:44 AM
Component/s: Highlighter
Affects Version/s: 1.6.1
Fix Version/s: 1.6.3

Time Tracking:
Not Specified


Operating System: All
Platform: All

Issuezilla Id: 1,311
Participants: kleopatra

 Description  « Hide

WrappingProvider guarantees to reset both icon and text in each round of config, so it
is safe to allow setting the Icon in the Highlighter

forum discussion

related Issue 1080 and Issue 1090

we might consider to add an interface IconAware with getters/setters for an icon property.
Its task would be to tag rendering components which are guaranteed to have their icons
reset by the provider, a provider would create rendering components implementing the interface,
if appropriate. The IconHighlighter would be only touch the icon if it detects the interface
(and plain JLabel for backward compatibility, all core renderers reset the icon as well,
not much harm done)


kleopatra added a comment - 05/Nov/10 03:39 AM

done as outlined above

  • added IconAware
  • changed JRendererLabel, WrappingIconPanel to implement IconAware
  • changed IconHighlighter to handle IconAware (as well as JLabel for backward compatibility)
  • updated ComponentProvider doc
  • added tests

kleopatra added a comment - 05/Nov/10 03:44 AM

all tests passing locally, Hudson still down closing anyway