swingx
  1. swingx
  2. SWINGX-1327

Regression: ColorHighlighter must not blend by default

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Works as designed
    • Affects Version/s: 1.6.1
    • Fix Version/s: 1.6.3
    • Component/s: Highlighter
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      1,327

      Description

      this was introduced with the addition of alpha blending support as of Issue 1002

      to expose see failing tests in HighlighterTest (after changing the highlighter colors
      to transparent)

      current discussion is
      http://forums.java.net/jive/thread.jspa?threadID=36538&tstart=0

      old discussion (with decision to not make the Highlighter go clever under the hood)
      http://forums.java.net/jive/thread.jspa?messageID=52792#52792

      marking as high priority defect to grab attention

      CU
      Jeanette

        Activity

        kleopatra created issue -
        kenaiadmin made changes -
        Field Original Value New Value
        issue.field.bugzillaimportkey 1327 85587
        Karl Schaefer made changes -
        Affects Version/s 1.6.1 [ 13360 ]
        Affects Version/s 1.6++ [ 13359 ]
        Hide
        Karl Schaefer added a comment -

        As I said in the forum post, which we can no longer access, I think the old behavior was broken. If I supply a non-opaque Color to a ColorHighlighter, I expect it to do the right thing and that is mix the supplied color with the current one, but that would not happen. It would simply override the current color without respecting its opacity.

        Given this bug's lack of attention and clients' lack of complaints a mix of two things is happening:
        1. Everyone is using fully opaque colors and sees no difference between old and new implementations.
        2. People who are using non-opaque colors are now seeing the behavior that they expect.

        That being said, I see no reason to leave this bug open.

        Show
        Karl Schaefer added a comment - As I said in the forum post, which we can no longer access, I think the old behavior was broken. If I supply a non-opaque Color to a ColorHighlighter, I expect it to do the right thing and that is mix the supplied color with the current one, but that would not happen. It would simply override the current color without respecting its opacity. Given this bug's lack of attention and clients' lack of complaints a mix of two things is happening: 1. Everyone is using fully opaque colors and sees no difference between old and new implementations. 2. People who are using non-opaque colors are now seeing the behavior that they expect. That being said, I see no reason to leave this bug open.
        Hide
        Karl Schaefer added a comment -

        SWINGX-1327: Remove legacy behavior mode, finalizing the blending changes.

        swingx-core/src/main/java/org/jdesktop/swingx/decorator/ColorHighlighter.java

        Committed revision 4020.

        Leaving bug title, but resolving as designed.

        Show
        Karl Schaefer added a comment - SWINGX-1327 : Remove legacy behavior mode, finalizing the blending changes. swingx-core/src/main/java/org/jdesktop/swingx/decorator/ColorHighlighter.java Committed revision 4020. Leaving bug title, but resolving as designed.
        Karl Schaefer made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Works as designed [ 7 ]

          People

          • Assignee:
            Karl Schaefer
            Reporter:
            kleopatra
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: