swingx
  1. swingx
  2. SWINGX-1347

StringValues: add type which is UIResource

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.2
    • Fix Version/s: 1.6.3
    • Component/s: Renderer
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      1,347

      Description

      StringValues can be used by a variety of clients. If installed by uiManagers, they should
      implement UIResource to mark them as such. Add wrapper to StringValues zoo

        Activity

        Hide
        kleopatra added a comment -

        added StringValueUIResource which wraps around a given StringValue
        added tests

        Show
        kleopatra added a comment - added StringValueUIResource which wraps around a given StringValue added tests
        Hide
        Karl Schaefer added a comment -

        Issue 1347: Updated DefaultsList to ensure that any SwingX supplied
        StringValues are UIResources.

        src/main/java/org/jdesktop/swingx/plaf/DefaultsList.java

        Committed revision 3785.

        Show
        Karl Schaefer added a comment - Issue 1347: Updated DefaultsList to ensure that any SwingX supplied StringValues are UIResources. src/main/java/org/jdesktop/swingx/plaf/DefaultsList.java Committed revision 3785.
        Hide
        Karl Schaefer added a comment -

        commit -m "Issue 1347: Updated DefaultsList to ensure that any SwingX supplied
        StringValues are UIResources." C:/workspace/swingx/swingx-
        core/src/main/java/org/jdesktop/swingx/plaf/DefaultsList.java
        Sending C:/workspace/swingx/swingx-
        core/src/main/java/org/jdesktop/swingx/plaf/DefaultsList.java
        Transmitting file data ...
        Committed revision 3785.

        Show
        Karl Schaefer added a comment - commit -m "Issue 1347: Updated DefaultsList to ensure that any SwingX supplied StringValues are UIResources." C:/workspace/swingx/swingx- core/src/main/java/org/jdesktop/swingx/plaf/DefaultsList.java Sending C:/workspace/swingx/swingx- core/src/main/java/org/jdesktop/swingx/plaf/DefaultsList.java Transmitting file data ... Committed revision 3785.
        Hide
        Karl Schaefer added a comment -

        What if the wrapped StringValue is a MappedValue? Seems like that would fail
        to provide the same results.

        Show
        Karl Schaefer added a comment - What if the wrapped StringValue is a MappedValue? Seems like that would fail to provide the same results.
        Hide
        kleopatra added a comment -

        oops ... good catches, both of your comments

        Re-opening - no time to look into the MappedValue right now, but sure need to handle it,
        darn, how could i forget that

        Thanks
        Jeanette

        Show
        kleopatra added a comment - oops ... good catches, both of your comments Re-opening - no time to look into the MappedValue right now, but sure need to handle it, darn, how could i forget that Thanks Jeanette
        Hide
        Karl Schaefer added a comment -

        You could alter StringValueUIResource to be a MappedValue. I think that just
        solves the issue.

        Show
        Karl Schaefer added a comment - You could alter StringValueUIResource to be a MappedValue. I think that just solves the issue.
        Hide
        kleopatra added a comment -

        Decided to add a separate class MappedValueUIResource. Feels safer than unconditionally
        extending the type of a plain StringValue by simply throwing it into the wrapper. Such
        a type extension might come as a surprise for developers.

        Plus the MappedValue is a ... ehem ... temporary clutch which survived Keeping that
        separate from the base makes it easier to cleanup eventually (harhar - as if that would
        ever happen <g>)

        Show
        kleopatra added a comment - Decided to add a separate class MappedValueUIResource. Feels safer than unconditionally extending the type of a plain StringValue by simply throwing it into the wrapper. Such a type extension might come as a surprise for developers. Plus the MappedValue is a ... ehem ... temporary clutch which survived Keeping that separate from the base makes it easier to cleanup eventually (harhar - as if that would ever happen <g>)

          People

          • Assignee:
            kleopatra
            Reporter:
            kleopatra
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: