swingx
  1. swingx
  2. SWINGX-1355

Better docuementation for Style.NONE

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.1
    • Fix Version/s: 1.6.3
    • Component/s: Painter
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      1,355

      Description

      There is no difference between Style.NONE and setVisible(false). Or rather
      there should be no difference. Most painters that use Style do not correctly
      respond to setVisible false. Remove Style.NONE as it is redundant and ensure
      that setVisible works correctly.

        Activity

        Hide
        Karl Schaefer added a comment -

        SWINGX-1355: Updated the documentation to spell out the differences between setVisible(false) and Style.NONE.

        swingx-painters/src/main/java/org/jdesktop/swingx/painter/AbstractAreaPainter.java

        Committed revision 3992.

        Show
        Karl Schaefer added a comment - SWINGX-1355 : Updated the documentation to spell out the differences between setVisible(false) and Style.NONE. swingx-painters/src/main/java/org/jdesktop/swingx/painter/AbstractAreaPainter.java Committed revision 3992.
        Hide
        Karl Schaefer added a comment -

        We need to leave Style.NONE. If the user has an AreaEffect on the Painter it will not display with setVisible(false), but will with Style.NONE.

        Show
        Karl Schaefer added a comment - We need to leave Style.NONE. If the user has an AreaEffect on the Painter it will not display with setVisible(false), but will with Style.NONE.
        Hide
        Karl Schaefer added a comment -

        Issue 1355: Remove Style.NONE. Marked as deprecated. SwingX deprecation
        removal process will remove NONE after the next release.

        swingx-
        painters/src/main/java/org/jdesktop/swingx/painter/AbstractAreaPainter.java
        swingx-painters/src/main/java/org/jdesktop/swingx/painter/ImagePainter.java
        swingx-painters/src/main/java/org/jdesktop/swingx/painter/RectanglePainter.java

        Committed revision 3839.

        Show
        Karl Schaefer added a comment - Issue 1355: Remove Style.NONE. Marked as deprecated. SwingX deprecation removal process will remove NONE after the next release. swingx- painters/src/main/java/org/jdesktop/swingx/painter/AbstractAreaPainter.java swingx-painters/src/main/java/org/jdesktop/swingx/painter/ImagePainter.java swingx-painters/src/main/java/org/jdesktop/swingx/painter/RectanglePainter.java Committed revision 3839.

          People

          • Assignee:
            Karl Schaefer
            Reporter:
            Karl Schaefer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: