swingx
  1. swingx
  2. SWINGX-1421

AbstractActionExt should use Action.SELECTED_KEY underneath is/setSelected

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.2
    • Fix Version/s: 1.6.3
    • Component/s: Action
    • Labels:
      None

      Description

      As of Java 1.6, Action now supports a selected state. We need to defer to that to ensure that our action will work correctly with core components.

        Activity

        Hide
        Karl Schaefer added a comment -

        Issue 1364 and Issue 1421: Updated AbstractActionExt to use the Action.SELECTED_KEY instead of managing the selection manually. The key is used by buttons to correctly autoconfigure as of 1.6. Began work on changing the type constraints for action command to String. Must finish that in the next release when we can change getActionCommand to String.

        swingx-action/src/main/java/org/jdesktop/swingx/action/AbstractActionExt.java
        swingx-action/src/test/java/org/jdesktop/swingx/action/AbstractActionExtTest.java
        swingx-action/src/test/java/org/jdesktop/swingx/action/ActionIssues.java
        swingx-action/src/test/java/org/jdesktop/swingx/action/ActionTest.java

        Committed revision 3999.

        Show
        Karl Schaefer added a comment - Issue 1364 and Issue 1421: Updated AbstractActionExt to use the Action.SELECTED_KEY instead of managing the selection manually. The key is used by buttons to correctly autoconfigure as of 1.6. Began work on changing the type constraints for action command to String. Must finish that in the next release when we can change getActionCommand to String. swingx-action/src/main/java/org/jdesktop/swingx/action/AbstractActionExt.java swingx-action/src/test/java/org/jdesktop/swingx/action/AbstractActionExtTest.java swingx-action/src/test/java/org/jdesktop/swingx/action/ActionIssues.java swingx-action/src/test/java/org/jdesktop/swingx/action/ActionTest.java Committed revision 3999.
        Hide
        kleopatra added a comment -

        careful: this change will heavily break all existing apps which listen to the "selected"! Need a more open and at the same time smoother transition than a hidden re-wire, f.i. keep the old notification for a while

        similar for any other keys that are updated to 1.6 (just saw the large-icon f.i.)

        would suggest to re-open this or alternatively create an umbrella issue

        Show
        kleopatra added a comment - careful: this change will heavily break all existing apps which listen to the "selected"! Need a more open and at the same time smoother transition than a hidden re-wire, f.i. keep the old notification for a while similar for any other keys that are updated to 1.6 (just saw the large-icon f.i.) would suggest to re-open this or alternatively create an umbrella issue
        Hide
        Karl Schaefer added a comment -

        Reopen to ensure a smoother transition for clients.

        Show
        Karl Schaefer added a comment - Reopen to ensure a smoother transition for clients.
        Hide
        Karl Schaefer added a comment -

        SWINGX-1421: Continue to fire selected for the next release. Depracted with warning that selected may stop working in the future.

        swingx-action/src/main/java/org/jdesktop/swingx/action/AbstractActionExt.java

        Committed revision 4103.

        Show
        Karl Schaefer added a comment - SWINGX-1421 : Continue to fire selected for the next release. Depracted with warning that selected may stop working in the future. swingx-action/src/main/java/org/jdesktop/swingx/action/AbstractActionExt.java Committed revision 4103.

          People

          • Assignee:
            Karl Schaefer
            Reporter:
            Karl Schaefer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: