swingx
  1. swingx
  2. SWINGX-1425

BlendComposite: BlendingModes implemented incorrectly

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.6.2
    • Fix Version/s: 1.6.3
    • Component/s: Graphics
    • Labels:
      None
    • Environment:

      all

      Description

      The BlendComposite-modes BlendComposite.GREEN & BlendComposite.BLUE are flipped.

        Activity

        Spinnifex created issue -
        Karl Schaefer made changes -
        Field Original Value New Value
        Assignee rah003 [ rah003 ] Karl Schaefer [ kschaefe ]
        Fix Version/s 1.6.3 [ 13366 ]
        Affects Version/s 1.6.2 [ 13362 ]
        Priority Major [ 3 ] Critical [ 2 ]
        Karl Schaefer made changes -
        Summary BlendComposite Failure BlendComposite: BlendingModes implemented incorrectly
        Karl Schaefer made changes -
        Comment [ In addition to GREEN and BLUE being flipped, most of our commutative modes are fliped:
        COLOR_BURN <-> INVERSE_COLOR_BURN
        COLOR_DODGE <-> INVERSE_COLOR_DODGE
        OVERLAY <-> HARD_LIGHT ]
        Hide
        Karl Schaefer added a comment -

        Issue 1441 and Issue 1425: Corrected the incorrect color implementations. Added some units tests that use "good" sought images to perform blending checks. (Would be good to integrate these into the JavaDoc.) Added the missing modes. Some modes still untested, but this is a lot better than before.

        swingx-core/src/main/java/org/jdesktop/swingx/graphics/BlendComposite.java
        swingx-core/src/test/java/org/jdesktop/swingx/graphics/BlendCompositeTest.java
        swingx-core/src/test/java/org/jdesktop/swingx/graphics/BlenderVisualCheck.java
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/add.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/blue-over-horizontal.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/color-burn-hov.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/color-burn-voh.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/color-dodge-hov.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/color-dodge-voh.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/darken.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/difference.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/exclusion.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/green-over-horizontal.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/hard-mix.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/horizontal.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/lighten.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/linear-light-hov.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/linear-light-voh.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/multiply.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/overlay-hov.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/overlay-voh.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/pin-light-hov.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/pin-light-voh.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/red-over-horizontal.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/screen.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/soft-burn-hov.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/soft-burn-voh.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/soft-light-hov.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/soft-light-voh.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/subtract.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/vertical.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/vivid-light-hov.gif
        swingx-core/src/test/resources/org/jdesktop/swingx/graphics/vivid-light-voh.gif

        Committed revision 3998.

        Show
        Karl Schaefer added a comment - Issue 1441 and Issue 1425: Corrected the incorrect color implementations. Added some units tests that use "good" sought images to perform blending checks. (Would be good to integrate these into the JavaDoc.) Added the missing modes. Some modes still untested, but this is a lot better than before. swingx-core/src/main/java/org/jdesktop/swingx/graphics/BlendComposite.java swingx-core/src/test/java/org/jdesktop/swingx/graphics/BlendCompositeTest.java swingx-core/src/test/java/org/jdesktop/swingx/graphics/BlenderVisualCheck.java swingx-core/src/test/resources/org/jdesktop/swingx/graphics swingx-core/src/test/resources/org/jdesktop/swingx/graphics/add.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/blue-over-horizontal.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/color-burn-hov.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/color-burn-voh.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/color-dodge-hov.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/color-dodge-voh.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/darken.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/difference.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/exclusion.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/green-over-horizontal.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/hard-mix.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/horizontal.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/lighten.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/linear-light-hov.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/linear-light-voh.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/multiply.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/overlay-hov.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/overlay-voh.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/pin-light-hov.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/pin-light-voh.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/red-over-horizontal.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/screen.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/soft-burn-hov.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/soft-burn-voh.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/soft-light-hov.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/soft-light-voh.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/subtract.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/vertical.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/vivid-light-hov.gif swingx-core/src/test/resources/org/jdesktop/swingx/graphics/vivid-light-voh.gif Committed revision 3998.
        Karl Schaefer made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Karl Schaefer
            Reporter:
            Spinnifex
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: