swingx
  1. swingx
  2. SWINGX-1472

Make RectanglePainter constructors consistent

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.6.3
    • Fix Version/s: 1.6.3
    • Component/s: Painter
    • Labels:
      None

      Description

      RectanglePainter's overloaded constructor of the form RectanglePainter(int, int, int, int, int, int, boolean, Paint, float, Paint) is setting both horizontal and vertical fill properties to true which is not consistent with the other constructors, this in turn causes unit tests to fail.

      Patch attached.

        Activity

        brettryan created issue -
        Hide
        Karl Schaefer added a comment -

        Actaully, I discovered this while fixing unit tests. The right thing is to make them consistant by determining the value of the supplied parameter and inferring the correct fill value.

        Show
        Karl Schaefer added a comment - Actaully, I discovered this while fixing unit tests. The right thing is to make them consistant by determining the value of the supplied parameter and inferring the correct fill value.
        Karl Schaefer made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.6.3 [ 13366 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            rah003
            Reporter:
            brettryan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 30 minutes
              30m
              Remaining:
              Remaining Estimate - 30 minutes
              30m
              Logged:
              Time Spent - Not Specified
              Not Specified