Issue Details (XML | Word | Printable)

Key: SWINGX-1472
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: rah003
Reporter: brettryan
Votes: 0
Watchers: 0

If you were logged in you would be able to see more operations.

Make RectanglePainter constructors consistent

Created: 15/Nov/11 04:04 PM   Updated: 15/Nov/11 06:32 PM   Resolved: 15/Nov/11 06:32 PM
Component/s: Painter
Affects Version/s: 1.6.3
Fix Version/s: 1.6.3

Time Tracking:
Original Estimate: 30 minutes
Original Estimate - 30 minutes
Remaining Estimate: 30 minutes
Remaining Estimate - 30 minutes
Time Spent: Not Specified
Time Spent - Not Specified

File Attachments: 1. Text File 0002-Corrected-constructor-to-match-overloaded-behaviour.patch (1 kB) 15/Nov/11 04:04 PM - brettryan

Participants: brettryan, Karl Schaefer and rah003

 Description  « Hide

RectanglePainter's overloaded constructor of the form RectanglePainter(int, int, int, int, int, int, boolean, Paint, float, Paint) is setting both horizontal and vertical fill properties to true which is not consistent with the other constructors, this in turn causes unit tests to fail.

Patch attached.

Karl Schaefer added a comment - 15/Nov/11 06:32 PM

Actaully, I discovered this while fixing unit tests. The right thing is to make them consistant by determining the value of the supplied parameter and inferring the correct fill value.