swingx
  1. swingx
  2. SWINGX-1514

Regression - WrappingProvider/Panel: background on icon even if not highlighted

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.6.3, 1.6.4
    • Fix Version/s: 1.6.5-1
    • Component/s: Misc Component, Renderer
    • Labels:
      None

      Description

      to reproduce, see f.i. the demo, any where a JXTree/Table has a background highlighter: the background color of the highlighted rows is showing behind all icons, even those in not-highlighted rows

      Regression, because it didn't behave like that in 1.6.2

      need to track where it really happened: candidates are the WrappingIconPanel itself, or maybe the JXPanel it extends

        Issue Links

          Activity

          Hide
          kleopatra added a comment -

          beause it's important to have it working now

          It's probably two issues

          • WrappingIconProvider allowing to configure whether the background of the wrapped component extends to the icon as well
          • JXPanel supporting configuration of whether or not the background should be painted

          As long as the second isn't available, the former can be handled by a the patch. As soon as the second will be available, the patch can be thrown out.

          Show
          kleopatra added a comment - beause it's important to have it working now It's probably two issues WrappingIconProvider allowing to configure whether the background of the wrapped component extends to the icon as well JXPanel supporting configuration of whether or not the background should be painted As long as the second isn't available, the former can be handled by a the patch. As soon as the second will be available, the patch can be thrown out.
          Hide
          Karl Schaefer added a comment -

          SWINGX-1514: Added a follow-up check to the AlphaPaintable clause to determine if the current alpha is less than 1. We assume if the alpha is 1 and the component is not opaque that we should prevent background painting. Also removed and inlined BackgroundPainter, which is no longer useful (was part of a previous iteration of this logic).

          swingx/swingx-core/src/main/java/org/jdesktop/swingx/renderer/WrappingIconPanel.java
          swingx-core/src/main/java/org/jdesktop/swingx/SwingXUtilities.java
          swingx-core/src/main/java/org/jdesktop/swingx/BackgroundPainter.java

          Committed revision 4252.

          Show
          Karl Schaefer added a comment - SWINGX-1514 : Added a follow-up check to the AlphaPaintable clause to determine if the current alpha is less than 1. We assume if the alpha is 1 and the component is not opaque that we should prevent background painting. Also removed and inlined BackgroundPainter, which is no longer useful (was part of a previous iteration of this logic). swingx/swingx-core/src/main/java/org/jdesktop/swingx/renderer/WrappingIconPanel.java swingx-core/src/main/java/org/jdesktop/swingx/SwingXUtilities.java swingx-core/src/main/java/org/jdesktop/swingx/BackgroundPainter.java Committed revision 4252.
          Hide
          kleopatra added a comment -

          still virulent for Nimbus (probably other synth-based lafs as well)

          runnable code now is in RendererVisualCheck (it used to work with the hack, so moved from issues to check - didn't check again when you removed the hack , same methods as earlier.

          Show
          kleopatra added a comment - still virulent for Nimbus (probably other synth-based lafs as well) runnable code now is in RendererVisualCheck (it used to work with the hack, so moved from issues to check - didn't check again when you removed the hack , same methods as earlier.
          Hide
          kleopatra added a comment -

          the underlying issue probably is the same as 1545

          Show
          kleopatra added a comment - the underlying issue probably is the same as 1545
          Hide
          Karl Schaefer added a comment -

          Looks fine when I run the visual check.

          Show
          Karl Schaefer added a comment - Looks fine when I run the visual check.

            People

            • Assignee:
              Karl Schaefer
              Reporter:
              kleopatra
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: