swingx
  1. swingx
  2. SWINGX-456

Rollover not working while dragging

    Details

    • Issuezilla Id:
      456

      Description

      I've just added a rollover highlighter to my JXList, and it works fine when I
      idly move the mouse over the list.

      However, I sometimes drop things on that list, and while the mousebutton is
      pressed (dragging), the rollover effect is not seen anymore.

      I think it also happens with JXTables. I'm dragging a row and while I'm over the
      table, no rollover is seen (this particular case could be due to JXTable not
      accepting that drop...)

        Issue Links

          Activity

          Hide
          kleopatra added a comment -

          taking ... and postponing. Sounds like a non-trivial issue: my guess is that the
          mouse events might be eaten by the drag ...

          Jeanette

          Show
          kleopatra added a comment - taking ... and postponing. Sounds like a non-trivial issue: my guess is that the mouse events might be eaten by the drag ... Jeanette
          Hide
          kleopatra added a comment -


          forgot to postpone - this issue wants to be solved right now <g>

          Show
          kleopatra added a comment - forgot to postpone - this issue wants to be solved right now <g>
          Hide
          Karl Schaefer added a comment -

          In the drag and drop case, this is not a bug. We should not update the visual
          display with the rollover. Any painting or updating should be part of the drag-
          and-drop facility.

          In the other case, when the user is performing a drag without intent to drop,
          in other words a click with a move but no release, we probably also don't want
          to follow the mouse. I'm not sure what state the user is expecting in that
          case, but the rollover renderer will update once the drag is complete (or
          should update).

          Jeanette, if you can confirm that a release from a drag without any additional
          movement causes the rollover to be in the correct location, I think we can
          close this as invalid or won't fix.

          We may want to provide easier mechanisms for drop location painting in SwingX,
          but not within the confines of the Rollover mechanism, and therefore not within
          the confines of this bug.

          Show
          Karl Schaefer added a comment - In the drag and drop case, this is not a bug. We should not update the visual display with the rollover. Any painting or updating should be part of the drag- and-drop facility. In the other case, when the user is performing a drag without intent to drop, in other words a click with a move but no release, we probably also don't want to follow the mouse. I'm not sure what state the user is expecting in that case, but the rollover renderer will update once the drag is complete (or should update). Jeanette, if you can confirm that a release from a drag without any additional movement causes the rollover to be in the correct location, I think we can close this as invalid or won't fix. We may want to provide easier mechanisms for drop location painting in SwingX, but not within the confines of the Rollover mechanism, and therefore not within the confines of this bug.
          Hide
          kleopatra added a comment -

          Karl,

          I agree with your evaluation

          • we don't want to interfere with any visual feedback during a dnd gesture
          • there's no general "right way" while dragging without dnd intention

          added a visual test case to RolloverVisualCheck ... and well ... the rollover is not updated
          on release. That's most probably a swingx bug in the rollover state update mechanism (best
          case would be if it would be a repaint-only issue). Need to dig.

          Show
          kleopatra added a comment - Karl, I agree with your evaluation we don't want to interfere with any visual feedback during a dnd gesture there's no general "right way" while dragging without dnd intention added a visual test case to RolloverVisualCheck ... and well ... the rollover is not updated on release. That's most probably a swingx bug in the rollover state update mechanism (best case would be if it would be a repaint-only issue). Need to dig.
          Hide
          kleopatra added a comment -
          • fixed RolloverProducer to fire a rollover_changed on released
          • added visual test method as how-to force rollover notification on dragging (custom RolloverProducer)

          we could support control about a notification-while-dragging property (not-dnd, that's
          safe enough, as those drag events never reach the producer) on the level of the RolloverProducer
          (and maybe on the level of the rollover-aware collection components as well). Not sure
          if it's common enough to bother? More code means more code to maintain .. Opinions, please?

          change committed in revision #3920

          Jeanette

          Show
          kleopatra added a comment - fixed RolloverProducer to fire a rollover_changed on released added visual test method as how-to force rollover notification on dragging (custom RolloverProducer) we could support control about a notification-while-dragging property (not-dnd, that's safe enough, as those drag events never reach the producer) on the level of the RolloverProducer (and maybe on the level of the rollover-aware collection components as well). Not sure if it's common enough to bother? More code means more code to maintain .. Opinions, please? change committed in revision #3920 Jeanette
          Hide
          Karl Schaefer added a comment -

          I say close as fixed; the original reporter was clearly talking about DnD
          dragging and not "normal" dragging. I really can't think of a use-case for
          normal dragging + rollover effects.

          Show
          Karl Schaefer added a comment - I say close as fixed; the original reporter was clearly talking about DnD dragging and not "normal" dragging. I really can't think of a use-case for normal dragging + rollover effects.
          Hide
          kleopatra added a comment -

          resolving as fixed

          Show
          kleopatra added a comment - resolving as fixed

            People

            • Assignee:
              kleopatra
              Reporter:
              agusmba
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: