swingx
  1. swingx
  2. SWINGX-896

ComponentProvider should be designed for extension

    Details

    • Issuezilla Id:
      896

      Description

      The ComponentAdapter is not completely designed for extension. The empty
      constructor allows develoepers to create improperly defined subclasses,
      resulting in misperforming StringValue requests.

      Furthermore, I recommend a StringValue name change. I like RendererValue. And
      Make it the base for all renderer values.

        Activity

        Hide
        kleopatra added a comment -

        haha, you didn't forget as I had hoped <g> Not sure if I'll tackle it any time
        soon, so for now postpone to final.

        I think the StringValue issue should have its own issue, or not? RendererValue
        as a name feels fine, but don't really like the idea of a base-class. Or if we
        go for it, maybe generics or a kind of per-type converter factory or something.
        Anyway, a bigger issue and not likely to be solved before final.

        Jeanette

        Show
        kleopatra added a comment - haha, you didn't forget as I had hoped <g> Not sure if I'll tackle it any time soon, so for now postpone to final. I think the StringValue issue should have its own issue, or not? RendererValue as a name feels fine, but don't really like the idea of a base-class. Or if we go for it, maybe generics or a kind of per-type converter factory or something. Anyway, a bigger issue and not likely to be solved before final. Jeanette
        Hide
        Karl Schaefer added a comment -

        To clarify for posterity, I was making a comment on ComponentProvider, not
        ComponentAdapter. Too many similar names.

        Anyway, I still feel the points about the null issues are very valid
        condsidering the need to have valid StringValues for WYSIWYM and other
        dependencies. So, again, just more of a reiteration of my point. Nothing new
        to add, but maybe if I keep repeating it, I can get my way.

        Show
        Karl Schaefer added a comment - To clarify for posterity, I was making a comment on ComponentProvider, not ComponentAdapter. Too many similar names. Anyway, I still feel the points about the null issues are very valid condsidering the need to have valid StringValues for WYSIWYM and other dependencies. So, again, just more of a reiteration of my point. Nothing new to add, but maybe if I keep repeating it, I can get my way.
        Hide
        kleopatra added a comment -

        postponed api enhacement issues which need deeper thinking/requirement analysis

        Show
        kleopatra added a comment - postponed api enhacement issues which need deeper thinking/requirement analysis
        Hide
        Karl Schaefer added a comment -

        Just wanted to pop this back on the radar with the current swath of API
        breaks. I know you moved it post 1.0, but with the CellContext change and the
        Abstract renaming, I thought I'd bring this back to your attention.

        Karl

        Show
        Karl Schaefer added a comment - Just wanted to pop this back on the radar with the current swath of API breaks. I know you moved it post 1.0, but with the CellContext change and the Abstract renaming, I thought I'd bring this back to your attention. Karl
        Hide
        kleopatra added a comment -

        haha ... knew you wouldn't give up <g>

        Don't see much of a probability to do it right now (not overly pressing, is
        it?), so keep it for post final.

        Jeanette

        Show
        kleopatra added a comment - haha ... knew you wouldn't give up <g> Don't see much of a probability to do it right now (not overly pressing, is it?), so keep it for post final. Jeanette
        Hide
        Karl Schaefer added a comment -

        This seems to have been solved, since at least the end of 2008. setStringValue
        which is used by the ComponentProvider constructors does not allow the setting
        of a null StringValue (it will implicitly coerce null to
        StringValues.TO_STRING).

        Show
        Karl Schaefer added a comment - This seems to have been solved, since at least the end of 2008. setStringValue which is used by the ComponentProvider constructors does not allow the setting of a null StringValue (it will implicitly coerce null to StringValues.TO_STRING).

          People

          • Assignee:
            kleopatra
            Reporter:
            Karl Schaefer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: