TrueZIP
  1. TrueZIP
  2. TRUEZIP-135

de.schlichtherle.truezip.fs.archive.FsDefaultArchiveController should be package private

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: TrueZIP 7.2
    • Fix Version/s: TrueZIP 7.2.1
    • Component/s: TrueZIP Kernel
    • Labels:
      None

      Description

      This class was declared public because it was once believed that sub-classing it would be required to implement the "archive appending" feature. In that case, it were up to the archive driver implementation to select the right class.

      This picture has changed, however. Selecting an archive entry collision strategy is now a matter of selecting the appropriate output preferences using TConfig.setOutputPreferences(...).

      Hence, this class is not required to be public anymore. To the contrary, declaring it package private enables to do some required refactorings, hence this change.

        Issue Links

          Activity

          Hide
          Christian Schlichtherle added a comment -

          Done.

          Show
          Christian Schlichtherle added a comment - Done.

            People

            • Assignee:
              Christian Schlichtherle
              Reporter:
              Christian Schlichtherle
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: