tyrus
  1. tyrus
  2. TYRUS-43

MessageHandler.CharacterStream onMessage method called for every received partial string

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: 1.0-b13, 1.0
    • Component/s: None
    • Labels:
      None

      Description

      see BlockingStreamingTextTest - it is currently ignored, as it breaks due to this bug.

      The client sends partial strings, and on the server side, it seems that for every partial string received, a new call to onMessage() method is made. I believe this is wrong (flawed) as the CharacterStream.onMessage() method has no means to determine when the last part of the string came - so IMO should receive the full string (i.e. keep receiving string parts until the last is received) rather than invoking new handler for every part.

      Once this bug is fixed, the @Ignore annotation should be removed from the test so that it runs as part of the build.

        Issue Links

          Activity

          Hide
          dannycoward added a comment -

          The endpointwrapper was creating a new blocking adapter for each partial message. Now this is fixed.

          The same issue held for blocking binary data, which the fix for this also fixes.

          I am holding off closing this issue until I've seen it work in hudson. Its working great in local and workspace tests.

          Show
          dannycoward added a comment - The endpointwrapper was creating a new blocking adapter for each partial message. Now this is fixed. The same issue held for blocking binary data, which the fix for this also fixes. I am holding off closing this issue until I've seen it work in hudson. Its working great in local and workspace tests.
          Hide
          Pavel Bucek added a comment -

          still not resolved in trunk.

          Show
          Pavel Bucek added a comment - still not resolved in trunk.

            People

            • Assignee:
              Pavel Bucek
              Reporter:
              Martin Matula
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: