updatecenter
  1. updatecenter
  2. UPDATECENTER-109

BETA: Column width(s) should be variable in the modules table

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: current
    • Fix Version/s: milestone 1
    • Component/s: gui
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      109

      Description

      Right now all the columns have the same width. As a result the name column is
      not clearly readable and select is too wide. Please adjust the default widths as
      appropriate.

        Activity

        Hide
        Nazrul added a comment -

        Fix by feb 05.

        Show
        Nazrul added a comment - Fix by feb 05.
        Hide
        raccah added a comment -

        Column widths are already variable - they just might need to be adjusted.

        Siraj is fixing the width of the first column as part of issue 107.
        Check with Steve for other column changes.

        Show
        raccah added a comment - Column widths are already variable - they just might need to be adjusted. Siraj is fixing the width of the first column as part of issue 107. Check with Steve for other column changes.
        Hide
        raccah added a comment -

        Also coordinate with Siraj as he is fixing some of this in issue 133, I believe.

        Show
        raccah added a comment - Also coordinate with Siraj as he is fixing some of this in issue 133, I believe.
        Hide
        Byron Nevins added a comment -

        I'm not too happy with the solution I made. It is a quick fix, that has the
        following advantages:

        (1) The code for setting the default column widths is moved outside of the
        fragile form-based java file
        (2) It is easy to play around with the numbers in the new java file
        DefaultColumnSizes.java

        The disadvantages (these are old problems that simply aren't addressed in this fix)

        (1) If the user changes the size of the main window, its position, or the size
        of the columns – none of this is persisted. I.e. the view is always reset to
        the defaults whenever the program is run

        (2) We really shouldn't be using a plain JTable for the view of the table. We
        should have a derived class. THis will bite us soon.

        (3) JTable is somewhat mysterious about how it sets column widths. Be careful
        changing the numbers!

        ------------
        My fix:

        The old code would set a preferred column width for each of the 5 columns with a
        seven (!!) element array of ints. These preferred sizes were completely
        ignored by Swing.

        Now a call is made to DefaultColumnSizes.setDefaultSize(column, i) which puts in
        preferred sizes that are NOT ignored by Swing.

        Show
        Byron Nevins added a comment - I'm not too happy with the solution I made. It is a quick fix, that has the following advantages: (1) The code for setting the default column widths is moved outside of the fragile form-based java file (2) It is easy to play around with the numbers in the new java file DefaultColumnSizes.java The disadvantages (these are old problems that simply aren't addressed in this fix) (1) If the user changes the size of the main window, its position, or the size of the columns – none of this is persisted. I.e. the view is always reset to the defaults whenever the program is run (2) We really shouldn't be using a plain JTable for the view of the table. We should have a derived class. THis will bite us soon. (3) JTable is somewhat mysterious about how it sets column widths. Be careful changing the numbers! ------------ My fix: The old code would set a preferred column width for each of the 5 columns with a seven (!!) element array of ints. These preferred sizes were completely ignored by Swing. Now a call is made to DefaultColumnSizes.setDefaultSize(column, i) which puts in preferred sizes that are NOT ignored by Swing.
        Hide
        raccah added a comment -

        There were 7 columns until Siraj removed 2 of them the other day while fixing
        another bug. Please add the copyright notice to the top of the new file.

        Show
        raccah added a comment - There were 7 columns until Siraj removed 2 of them the other day while fixing another bug. Please add the copyright notice to the top of the new file.

          People

          • Assignee:
            Byron Nevins
            Reporter:
            sv96363
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: