Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: current
    • Fix Version/s: milestone 1
    • Component/s: core
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      162

      Description

      The cancel button does not work as follows:

      Go to Available Software tab
      Select something
      press install
      press cancel immediately after the cancel button appears

      Nothing is canceled. It goes ahead and downloads it anyways and it appears in
      the installed software tab

        Activity

        Hide
        Snjezana Sevo-Zenzerovic added a comment -

        Backend changes in downloader and installer as instructed by Satish and some
        basic UI changes to handle STOPPED overall download/installation status have
        been implemented. At this point I will need to transfer this bug to GUI
        subcomponent to take care of following remaining issues:

        • Right now, stopped installation is handled in the same way as failed
          installation based on reported aggregated STOPPED status and UI is not checking
          for isStopCompleted() value. This may need to be further improved, since right
          now status bar is left at the state it was when download/installation were
          stopped and in some cases I noticed inconsistent update of available software
          and installed software table contents.
        • When installation is being cancelled, it seems that UI is not setting proper
          progress object value since isStopRequested() checked by installer never gets
          set to true and installation is eventually stopped only at the point where
          subsequent module installation should be started. This should be fixed.
        Show
        Snjezana Sevo-Zenzerovic added a comment - Backend changes in downloader and installer as instructed by Satish and some basic UI changes to handle STOPPED overall download/installation status have been implemented. At this point I will need to transfer this bug to GUI subcomponent to take care of following remaining issues: Right now, stopped installation is handled in the same way as failed installation based on reported aggregated STOPPED status and UI is not checking for isStopCompleted() value. This may need to be further improved, since right now status bar is left at the state it was when download/installation were stopped and in some cases I noticed inconsistent update of available software and installed software table contents. When installation is being cancelled, it seems that UI is not setting proper progress object value since isStopRequested() checked by installer never gets set to true and installation is eventually stopped only at the point where subsequent module installation should be started. This should be fixed.
        Hide
        raccah added a comment -

        Snjezana, for 1, is it just a matter of the message (installation/download
        failed vs. cancelled)? Or is there more to it? Steve, any comment on how the
        ui should behave on cancel (specifically the progress bar)?

        For 2, the ui calls progressObject.stop(); Are you saying that the
        progressObject known to that method is not the instance that needs to be stopped?

        Show
        raccah added a comment - Snjezana, for 1, is it just a matter of the message (installation/download failed vs. cancelled)? Or is there more to it? Steve, any comment on how the ui should behave on cancel (specifically the progress bar)? For 2, the ui calls progressObject.stop(); Are you saying that the progressObject known to that method is not the instance that needs to be stopped?
        Hide
        locolobo added a comment -

        If a user hits the Cancel button during a download or installation the GUI
        should do the following:

        • As soon as the user hits Cancel, the Cancel button should be disabled to
          notify the user the input has been accepted. Also the progress bar should go
          back to zero.
        • The progress bar text should change to "Canceling installation..." and the
          progress bar should start showing progress of the Cancel:
        • "Canceling Installation..."
        • "Cleaning up..."

        When finished it should say "Installation Canceled".

        Show
        locolobo added a comment - If a user hits the Cancel button during a download or installation the GUI should do the following: As soon as the user hits Cancel, the Cancel button should be disabled to notify the user the input has been accepted. Also the progress bar should go back to zero. The progress bar text should change to "Canceling installation..." and the progress bar should start showing progress of the Cancel: "Canceling Installation..." "Cleaning up..." When finished it should say "Installation Canceled".
        Hide
        raccah added a comment -

        Cancel button is disabled. The rest needs to be handled on the backend

        Show
        raccah added a comment - Cancel button is disabled. The rest needs to be handled on the backend
        Hide
        Snjezana Sevo-Zenzerovic added a comment -

        Downgrading to P4 since the original reported issue has been addressed.
        Remaining installation/download cancellation progress reporting will be fixed in
        the backend.

        Show
        Snjezana Sevo-Zenzerovic added a comment - Downgrading to P4 since the original reported issue has been addressed. Remaining installation/download cancellation progress reporting will be fixed in the backend.

          People

          • Assignee:
            Snjezana Sevo-Zenzerovic
            Reporter:
            Byron Nevins
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: