updatecenter2
  1. updatecenter2
  2. UPDATECENTER2-1782

pkg.bat has incorrect EOL characters on Windows

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: B40
    • Component/s: bootstrap
    • Labels:
      None
    • Environment:

      Operating System: Windows XP
      Platform: Other

    • Issuezilla Id:
      1,782
    • Tags:

      Description

      This is mirror issue for:

      https://glassfish.dev.java.net/issues/show_bug.cgi?id=6788

      Quoting relevant description:

      When opening asadmin.bat and updatetool.bat with NOTEPAD.EXE, I can read them
      nicely.

      But pkg.bat is written in a single line with ugly boxes instead of CR LFs.

      It seems that file uses UNIX style EOL, while it must use CR LFs since it is a
      Windows batch.

      Note: updatetool.bat has been replaced with updatetool.exe since the issue was
      filed, but current 2.3 pkg.bat still has the same issue.

        Activity

        Hide
        Joe Di Pol added a comment -

        I did a quick audit of our scripts and the following
        bat files need to be converted to Windows EOL:

        cmprepo.bat
        pkg.bat
        pkg.depotd.bat
        pkgrecv.bat
        pkgsend.bat
        pkg-wrapper.bat
        updatetool.bat

        Since we are now on our final build, which is a stopper only
        build I'm targeting this cleanup for the next release. If the
        GlassFish team considers this a stopper let me know ASAP and I'll
        addresses it in 2.3.
        updatetoolconfig.bat
        updatetool-wrapper.bat

        Show
        Joe Di Pol added a comment - I did a quick audit of our scripts and the following bat files need to be converted to Windows EOL: cmprepo.bat pkg.bat pkg.depotd.bat pkgrecv.bat pkgsend.bat pkg-wrapper.bat updatetool.bat Since we are now on our final build, which is a stopper only build I'm targeting this cleanup for the next release. If the GlassFish team considers this a stopper let me know ASAP and I'll addresses it in 2.3. updatetoolconfig.bat updatetool-wrapper.bat
        Hide
        Snjezana Sevo-Zenzerovic added a comment -

        I wouldn't consider it a stopper for v3 FCS and it can be addressed in 2.3
        update release or in 2.4.

        Show
        Snjezana Sevo-Zenzerovic added a comment - I wouldn't consider it a stopper for v3 FCS and it can be addressed in 2.3 update release or in 2.4.
        Hide
        Joe Di Pol added a comment -

        Fixed in r2503

        Show
        Joe Di Pol added a comment - Fixed in r2503
        Hide
        arvindpachunoori added a comment -

        Verified on Windows 2003
        Working as expected and now incorrect characters are not found in each EOL and
        file is properly formatted

        Show
        arvindpachunoori added a comment - Verified on Windows 2003 Working as expected and now incorrect characters are not found in each EOL and file is properly formatted
        Hide
        Joe Di Pol added a comment -


        Fixed in 2.3u2: r2721

        Show
        Joe Di Pol added a comment - Fixed in 2.3u2: r2721

          People

          • Assignee:
            Joe Di Pol
            Reporter:
            Snjezana Sevo-Zenzerovic
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: