updatecenter2
  1. updatecenter2
  2. UPDATECENTER2-1885

Recent maven-makepkgs-plugin versions do not work with remote repo

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: current
    • Fix Version/s: B45
    • Component/s: tools
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

      Description

      maven-makepkgs-plugin versions 0.4 and 0.5 do not work at all if remote
      repository URL value (i.e. one starting with "http://" ) is specified in plugin
      configuration. Plugin execution fails because in this particular scenario plugin
      always attempts to invoke makepkgs with -t option, but without -d option and
      this combination is (understandably) not accepted.

      Looking at the latest maven-makepkgs-plugin mojo class code, it is obvious that
      the attempt to preserve backward compatibility backfired. -t option is always
      set as the result of the fact that plugin sets the default value for packageFile
      parameter. On the other hand, -d option is not set if plugin determines that
      repourl parameter points to remote repository (as it needs to in GF build).

      IMO, if repourl points to remote repository, plugin should take that to mean
      that it should not bother with the creation of local package image, i.e. values
      of packageFile, destFile, localRepository and attach parameters should be
      disregarded. Even sacrificing some of backward compatibility is more acceptable
      than the current state...

      I am filing this as P2 since major functionality is broken without obvious
      workaround. On the other hand, it is not a stopper for GF v3 release since we
      dropped AIX support so there is no urgent need to move to 0.5.

        Issue Links

          Activity

          Hide
          Snjezana Sevo-Zenzerovic added a comment -

          Adding magical keyword...

          Show
          Snjezana Sevo-Zenzerovic added a comment - Adding magical keyword...
          Hide
          Alexis MP added a comment -

          cc

          Show
          Alexis MP added a comment - cc
          Hide
          rajkumarsrinivasan added a comment -

          Fixed in revision 2620. Need to publish the new jar. The current 0.5 version jar will
          be replaced by the new jar since it is a one line change.

          Show
          rajkumarsrinivasan added a comment - Fixed in revision 2620. Need to publish the new jar. The current 0.5 version jar will be replaced by the new jar since it is a one line change.
          Hide
          rajkumarsrinivasan added a comment -

          The new jar is published. 0.5 version will work fine now. snjezana if you still

          Show
          rajkumarsrinivasan added a comment - The new jar is published. 0.5 version will work fine now. snjezana if you still
          Hide
          rajkumarsrinivasan added a comment -

          The new jar is published. 0.5 version will work fine now.

          Show
          rajkumarsrinivasan added a comment - The new jar is published. 0.5 version will work fine now.
          Hide
          rajkumarsrinivasan added a comment -

          Back ported to 2.3u2 in revision 2726.

          Show
          rajkumarsrinivasan added a comment - Back ported to 2.3u2 in revision 2726.

            People

            • Assignee:
              rajkumarsrinivasan
              Reporter:
              Snjezana Sevo-Zenzerovic
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: