VisualVM
  1. VisualVM
  2. VISUALVM-262

On VisualGC tab, disable checkboxes if feature not available

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.1.1
    • Fix Version/s: dev
    • Component/s: plugins
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      262

      Description

      This is with VVM 1.1.1 (not listed in your version list on the issue tracker).

      Minor nit: using the new VisualGC tab, the Histogram checkbox is enabled, but
      when I click it, the sub-section for histo displays with the message, "not
      available for this vm". I need to click this box for every VM I open just to see...

      1) disable checkbox in this case
      2) provide either a tooltip on the checkbox with this information, or place it
      somewhere else on the tab

        Activity

        Hide
        jsedlacek added a comment -

        The problem here is that just disabling the checkbox here doesn't give any
        feedback to the user why it's disabled. A tooltip has also quite bad visibility.

        The histogram is hidden only when not available (for example server VM), it's
        displayed by default when available. So you don't need to click the checkbox
        every time - if it's unchecked and the view is hidden, there's nothing to display.

        Could you please verify that the Histogram is shown for you when available? If
        true, I'm going to close this RFE.

        Show
        jsedlacek added a comment - The problem here is that just disabling the checkbox here doesn't give any feedback to the user why it's disabled. A tooltip has also quite bad visibility. The histogram is hidden only when not available (for example server VM), it's displayed by default when available. So you don't need to click the checkbox every time - if it's unchecked and the view is hidden, there's nothing to display. Could you please verify that the Histogram is shown for you when available? If true, I'm going to close this RFE.
        Hide
        pdoubleya added a comment -

        Confirmed that Histogram is available for other VMs on the same machine.

        I disagree with your assessment, however. If a feature is not usable, a checkbox
        should be disabled. There's no reason to check the box and then be told, no,
        it's not really available. I don't use VVM often enough (e.g. not every day)
        that I can recall why such settings are the way they are when I open the app.
        For example, does unchecked mean

        • not available in this VM?
        • expensive operation! disabled by default!
        • you unchecked this box the last time you opened VVM

        Personally, I think that in the future VVM should support more configurability
        that persists across sessions, so I would expect that I could uncheck the Histo
        box and have it remain unchecked when I next open VVM. While that's not a
        feature now, that would be in line with other GUI apps with many user-selectable
        options.

        If you don't feel the tooltip is easy enough, I'd just add a single line of text
        below "refresh rate" in this case, saying "Histogram not supported by this VM".
        But that's just me...

        Thanks!

        Show
        pdoubleya added a comment - Confirmed that Histogram is available for other VMs on the same machine. I disagree with your assessment, however. If a feature is not usable, a checkbox should be disabled. There's no reason to check the box and then be told, no, it's not really available. I don't use VVM often enough (e.g. not every day) that I can recall why such settings are the way they are when I open the app. For example, does unchecked mean not available in this VM? expensive operation! disabled by default! you unchecked this box the last time you opened VVM Personally, I think that in the future VVM should support more configurability that persists across sessions, so I would expect that I could uncheck the Histo box and have it remain unchecked when I next open VVM. While that's not a feature now, that would be in line with other GUI apps with many user-selectable options. If you don't feel the tooltip is easy enough, I'd just add a single line of text below "refresh rate" in this case, saying "Histogram not supported by this VM". But that's just me... Thanks!

          People

          • Assignee:
            jsedlacek
            Reporter:
            pdoubleya
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: