Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0
    • Labels:
      None

      Description

      Extensions currently returns Map<String, String> which does not imply any ordering; List<Parameter> might to be better match for this case.

      See http://java.net/projects/grizzly/sources/git/content/modules/websockets/src/main/java/org/glassfish/grizzly/websockets/Extension.java?rev=d4b481377b0c274236147cc4c379618a51f3a6d6

        Activity

        Hide
        dannycoward added a comment -

        Yes I think I agree. Although I can't find anything in the RFC that indicates that the order of the parameters is significant, they are held in an order in the http headers. Since the general rule for the parameters seems to be that each extension can treat that as it wishes (for example, some extensions disallow any parameters, or are asked to ignore 'unknown' ones) the API should preserve the order for any extension that wants to know it.

        Show
        dannycoward added a comment - Yes I think I agree. Although I can't find anything in the RFC that indicates that the order of the parameters is significant, they are held in an order in the http headers. Since the general rule for the parameters seems to be that each extension can treat that as it wishes (for example, some extensions disallow any parameters, or are asked to ignore 'unknown' ones) the API should preserve the order for any extension that wants to know it.
        Hide
        markt_asf added a comment -

        +1 to retaining the order

        Show
        markt_asf added a comment - +1 to retaining the order
        Hide
        dannycoward added a comment -

        still discussing in expert group

        Show
        dannycoward added a comment - still discussing in expert group
        Hide
        dannycoward added a comment -

        This is fixed as suggested in v012

        Show
        dannycoward added a comment - This is fixed as suggested in v012

          People

          • Assignee:
            dannycoward
            Reporter:
            Pavel Bucek
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:
              Resolved: