websocket-spec
  1. websocket-spec
  2. WEBSOCKET_SPEC-127

Consider removing setBufferSize() on containers

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      so it doesn't need to be checked all the time

        Activity

        Hide
        markt_asf added a comment -

        Some related issues:

        1. Session has one limit for text and binary messages whereas WebSocketContainer has separate limits. Need to be consistent.

        2. The method names should be consistent between Session and WebSocketContainer (unless of course they are meant to be completely different concepts in which case much more explantion in the Javadoc is required).

        3. Make clear if the limits are for incoming, outgoing or both. The assumption from the EG list is incoming only.

        4. Why allow limits greater than Integer.MAX_VALUE when that is the largest message / partial message Java is able to deliver?

        Show
        markt_asf added a comment - Some related issues: 1. Session has one limit for text and binary messages whereas WebSocketContainer has separate limits. Need to be consistent. 2. The method names should be consistent between Session and WebSocketContainer (unless of course they are meant to be completely different concepts in which case much more explantion in the Javadoc is required). 3. Make clear if the limits are for incoming, outgoing or both. The assumption from the EG list is incoming only. 4. Why allow limits greater than Integer.MAX_VALUE when that is the largest message / partial message Java is able to deliver?
        Hide
        dannycoward added a comment - - edited

        So I'm proposing:-

        1. separate text/binary limits on session to make it consistent with WebSOcketContainer.
        2. Put Default in the WebSocketContainer method names + javadoc to disambiguate all session/session override.
        3. Clarify limits for incoming only. Explore outgoing buffer size control in .next.
        4. Make limits ints.

        Show
        dannycoward added a comment - - edited So I'm proposing:- 1. separate text/binary limits on session to make it consistent with WebSOcketContainer. 2. Put Default in the WebSocketContainer method names + javadoc to disambiguate all session/session override. 3. Clarify limits for incoming only. Explore outgoing buffer size control in .next. 4. Make limits ints.
        Hide
        dannycoward added a comment -

        resolved as proposed.

        Show
        dannycoward added a comment - resolved as proposed.

          People

          • Assignee:
            dannycoward
            Reporter:
            dannycoward
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:
              Resolved: