websocket-spec
  1. websocket-spec
  2. WEBSOCKET_SPEC-133

DefaultServerConfiguration#getEndpointClass() should return Class<? extends Endpoint>

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      When the endpoint class is set, the parameter passed to the constructor is of type:
      Class<? extends Endpoint>

      Therefore, getEndpointClass() should return the same type.

        Activity

        Hide
        dannycoward added a comment -

        We also have annotated endpoints to deal with here - in which the endpoint class is the class of the POJO which could be anything.

        When I send out the proposed reshaping of the config APIs I think this should become clearer.

        Show
        dannycoward added a comment - We also have annotated endpoints to deal with here - in which the endpoint class is the class of the POJO which could be anything. When I send out the proposed reshaping of the config APIs I think this should become clearer.
        Hide
        markt_asf added a comment -

        Ah. I wasn't thinking about POJOs. In which case, the constructor for DefaultServerConfiguration needs to be changed.

        Happy to wait to see the new config APIs before progressing this.

        Show
        markt_asf added a comment - Ah. I wasn't thinking about POJOs. In which case, the constructor for DefaultServerConfiguration needs to be changed. Happy to wait to see the new config APIs before progressing this.
        Hide
        dannycoward added a comment -

        ok. now you can look at the new apis - I think they tighten things up considerably - do take a look when you get chance !

        Show
        dannycoward added a comment - ok. now you can look at the new apis - I think they tighten things up considerably - do take a look when you get chance !
        Hide
        dannycoward added a comment -

        This is definately fixed in the cleaned up APIs, so I am closing this one out.

        Show
        dannycoward added a comment - This is definately fixed in the cleaned up APIs, so I am closing this one out.

          People

          • Assignee:
            dannycoward
            Reporter:
            markt_asf
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: