websocket-spec
  1. websocket-spec
  2. WEBSOCKET_SPEC-140

Clarify relationship between WebSocketContainer#setMaxSessionIdleTimeout() and Session#setTimeout()

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      It isn't clear from the Javadoc what the relationship is between these two. I see two options:

      1. WebSocketContainer#setMaxSessionIdleTimeout() sets the default for Session#setTimeout()

      2. WebSocketContainer#setMaxSessionIdleTimeout() sets the maximum permitted timeout and Session#setTimeout() may not exceed this.

      My guess is that the intended behaviour is 1 to align with how max buffer size is handled. Maybe make the method name setDefaultSessionIdleTimeout() ?

      On a related note are zero or negative input values allowed for WebSocketContainer#setMaxSessionIdleTimeout() and if so, what do they mean? My guess is the same as for Session#setTimeout().

        Activity

          People

          • Assignee:
            dannycoward
            Reporter:
            markt_asf
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: