Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

          /**
           * This method is called with the endpoint configuration object of the
           * endpoint this decoder is intended for when
           * it is about to be brought into service, and with {@code null} when
           * the implementation has finished using it.
           *
           * @param config the endpoint configuration object if being brought into use
           * or {@code null} if being taken out of use.
           */
          void setEndpointConfig(EndpointConfig config);

      please rename to something else(/or adjust documentation). This is not "setter", this is lifecycle controller.

      Additionally, consider changing Encoder/Decoder to abstract class which has setEndpointConfig implemented, because it is not needed for majority of implementations (educated guess).

        Issue Links

          Activity

          Hide
          dannycoward added a comment -

          The APi has been renamed to follow the init()/destroy() pattern of the servlet api.

          Encoder and Decoder now have Adapter implementations as a convenience for developers who don't need to do anything with the lifecycle methods.

          Show
          dannycoward added a comment - The APi has been renamed to follow the init()/destroy() pattern of the servlet api. Encoder and Decoder now have Adapter implementations as a convenience for developers who don't need to do anything with the lifecycle methods.

            People

            • Assignee:
              dannycoward
              Reporter:
              Pavel Bucek
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: