websocket-spec
  1. websocket-spec
  2. WEBSOCKET_SPEC-20

API issues: long list of smaller issues to fix

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      These were reported by Mark Thomas - thankyou Mark.

      1. DecodeException / EncodeException
      Parameter ordering is inconsistent
      (ByteBuffer, String) vs. (String, Object)

      2. DefaultClientConfiguration
      getExtensions() returns null
      setExtensions() has a parameter of preferredExtensions
      (should probably be extensions)

      3. CloseReason
      No accessor for closeCode
      No accessor for reasonPhrase

      4. Methods in public interfaces do not themselves need to be declared
      public. (style issue / choice)

      5. Endpoint
      Parameter ordering is inconsistent
      onClose(Session, CloseReason) vs. onError(Throwable, Session)
      Parameter naming is inconsistent s vs. session

      6. Generics
      API uses raw types in a few places.

      7. Session
      s/getRemoteL/getRemote/

        Activity

        dannycoward created issue -
        Hide
        dannycoward added a comment -

        awaiting further feedback from expert group

        Show
        dannycoward added a comment - awaiting further feedback from expert group
        dannycoward made changes -
        Field Original Value New Value
        Assignee dannycoward [ dannycoward ]
        dannycoward made changes -
        Due Date 2012-11-09 00:00:00.0
        Hide
        dannycoward added a comment -

        These are fixed in API repo

        Show
        dannycoward added a comment - These are fixed in API repo
        dannycoward made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            dannycoward
            Reporter:
            dannycoward
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:
              Resolved: