Issue Details (XML | Word | Printable)

Key: WEBSOCKET_SPEC-20
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: dannycoward
Reporter: dannycoward
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
websocket-spec

API issues: long list of smaller issues to fix

Created: 12/Oct/12 10:15 PM   Updated: 03/Nov/12 12:22 AM  Due: 09/Nov/12   Resolved: 03/Nov/12 12:22 AM
Component/s: None
Affects Version/s: None
Fix Version/s: None

Time Tracking:
Not Specified

Tags:
Participants: dannycoward


 Description  « Hide

These were reported by Mark Thomas - thankyou Mark.

1. DecodeException / EncodeException
Parameter ordering is inconsistent
(ByteBuffer, String) vs. (String, Object)

2. DefaultClientConfiguration
getExtensions() returns null
setExtensions() has a parameter of preferredExtensions
(should probably be extensions)

3. CloseReason
No accessor for closeCode
No accessor for reasonPhrase

4. Methods in public interfaces do not themselves need to be declared
public. (style issue / choice)

5. Endpoint
Parameter ordering is inconsistent
onClose(Session, CloseReason) vs. onError(Throwable, Session)
Parameter naming is inconsistent s vs. session

6. Generics
API uses raw types in a few places.

7. Session
s/getRemoteL/getRemote/