websocket-spec
  1. websocket-spec
  2. WEBSOCKET_SPEC-44

Clarify default handshake negotation and corner cases

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Update to javadoc for

      DefaultClientEndpointConfiguration/ ClientEndpointConfiguration.getPreferredSubprotocol getPreferredExtensions
      DefaultServerEndpointConfiguration/ServerEndpointConfiguration getNegotiatedSubprotocol and getNegotiatedExtensions

      Propose: Use null for no value / no values rather than empty lists or strings.

      Also need to define the default algorithms for the server choosing the subprotocols and extensions.

      Propose: for subprotocols, the default DefaultServerEndpointConfiguration will find the 'best match' by returning the first subprotocol in the client list that it has in its own list.

      Propose: for extensions, the default DefaultServerEndpointConfiguration will find the 'best matches' by running through the clients preferred list in the order that it came, selecting, in that order, the extensions that it supports in its own server list.

      For the Origin check, will Propose the the default handshake will verify the Origin header, if present. See http://tools.ietf.org/html/rfc6455#section-4.2 , paragraph 4.

        Activity

        dannycoward created issue -
        dannycoward made changes -
        Field Original Value New Value
        Description Update to javadoc for

        DefaultClientEndpointConfiguration/ ClientEndpointConfiguration.getPreferredSubprotocol getPreferredExtensions
        DefaultServerEndpointConfiguration/ServerEndpointConfiguration getNegotiatedSubprotocol and getNegotiatedExtensions

        Propose: Use null for no value / no values rather than empty lists or strings.

        Also need to define the default algorithms for the server choosing the subprotocols and extensions.

        Propose: for subprotocols, the default DefaultServerEndpointConfiguration will find the 'best match' by returning the first subprotocol in the client list that it has in its own list.

        Propose: for extensions, the default DefaultServerEndpointConfiguration will find the 'best matches' by running through the clients preferred list in the order that it came, selecting, in that order, the extensions that it supports in its own server list.

        Update to javadoc for

        DefaultClientEndpointConfiguration/ ClientEndpointConfiguration.getPreferredSubprotocol getPreferredExtensions
        DefaultServerEndpointConfiguration/ServerEndpointConfiguration getNegotiatedSubprotocol and getNegotiatedExtensions

        Propose: Use null for no value / no values rather than empty lists or strings.

        Also need to define the default algorithms for the server choosing the subprotocols and extensions.

        Propose: for subprotocols, the default DefaultServerEndpointConfiguration will find the 'best match' by returning the first subprotocol in the client list that it has in its own list.

        Propose: for extensions, the default DefaultServerEndpointConfiguration will find the 'best matches' by running through the clients preferred list in the order that it came, selecting, in that order, the extensions that it supports in its own server list.

        For the Origin check, will Propose the the default handshake will verify the Origin header, if present. See http://tools.ietf.org/html/rfc6455#section-4.2 , paragraph 4.


        dannycoward made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Tags v008
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            dannycoward
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: