websocket-spec
  1. websocket-spec
  2. WEBSOCKET_SPEC-82

@WebSocketEndpoint's configuration attribute

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      At present (PR draft), @WebSocketEndpoint has a configuration attribute that is a required attribute. This means all the applications (even if they don't want to configure anything) need to pass a subclass of DefaultServerConfiguration. IMO, that's not usuable at all.

      DefaultServerConfiguration also has methods to set encoder, decoders and that would conflict with @WebSocketEndpoint's encoders/decoders attributes. That means spec need to define how an impl would construct effective encoders and decoders list.
      Moreover, the signature should be something like the following :
      public Class<? extends ServerEndpointConfiguration> configuration() default DefaultServerConfiguration.class;

      Then, the spec need to define how the configuration object is instantiated and whether it is used per instance or not etc.

        Activity

        Hide
        Pavel Bucek added a comment -

        additionally (I can create a separate issue if needed), Default(Server|Client)Configuration should not be part of API (or I don't see any reason for it). It is just implementation detail => it belongs to implementation.

        Show
        Pavel Bucek added a comment - additionally (I can create a separate issue if needed), Default(Server|Client)Configuration should not be part of API (or I don't see any reason for it). It is just implementation detail => it belongs to implementation.
        Hide
        dannycoward added a comment -



        The issues are all now resolved in v013 with the cleaned up config APIs.

        Show
        dannycoward added a comment - The issues are all now resolved in v013 with the cleaned up config APIs.

          People

          • Assignee:
            dannycoward
            Reporter:
            jitu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:
              Resolved: