Issue Details (XML | Word | Printable)

Key: WEBSOCKET_SPEC-84
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: dannycoward
Reporter: jitu
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
websocket-spec

Typo WebSocketResponse#getHeaders()

Created: 03/Jan/13 02:38 AM   Updated: 09/Jan/13 12:35 AM   Resolved: 09/Jan/13 12:35 AM
Component/s: None
Affects Version/s: None
Fix Version/s: None

Time Tracking:
Not Specified

Tags: v012
Participants: dannycoward and jitu


 Description  « Hide

/**

  • Return the list of Http Headers that came with the handshake request.
    *
  • @return the headers.
    */
    Map<String, List<String>> getHeaders();

Note "handshake request" instead of "handshake response" in the above javadoc

Also, the returned Map is modifiable and any changes to the map would be reflected in the handshake response headers. This is not clear from javadoc.

Will the returned Map would be empty or filled with headers the runtime is planning to send ?



dannycoward added a comment - 09/Jan/13 12:35 AM

I have updated the javadoc to detail what the handshake response is.

The ClientEndpointConfiguration and ServerEndpointConfiguration interception methods clarify the semantics of what the HandshakeResponse objects represent at the two key points in the opening handshake interaction, and what can be inspected/modified when.