Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Bunch of changes for CloseReason class

      • Add final modifier for fields
      • UTF-8 encoded bytes for reasonPhrase cannot be greater than 123 bytes. Throw IllegalArgumentException in that case.
      • enum constants for status codes need be documented. Otherwise, javadoc would be empty

      Looks like cannot attach the patch. Will send by email.

      If a close frame doesn't include status code, the Endpoint#onClose() is invoked with a CloseReason. What would be the value of CloseReason#getCloseCode() return in that case ? Would it be 1005 ? Good to include that in the spec.

        Activity

        Hide
        dannycoward added a comment -

        done - thanks !

        Show
        dannycoward added a comment - done - thanks !
        Hide
        Pavel Bucek added a comment -

        please add null checks; constructor and toString method can end with throwing NPE.

        Show
        Pavel Bucek added a comment - please add null checks; constructor and toString method can end with throwing NPE.
        Hide
        dannycoward added a comment -

        all updated in v012

        Show
        dannycoward added a comment - all updated in v012
        Hide
        Pavel Bucek added a comment -

        also please add usable CloseReason.toString() implementation.

        Show
        Pavel Bucek added a comment - also please add usable CloseReason.toString() implementation.

          People

          • Assignee:
            dannycoward
            Reporter:
            jitu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: