xadisk
  1. xadisk
  2. XADISK-115

JBoss 7.1 expects #run() and #release to be explicitly declared

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.2.1
    • Fix Version/s: 1.2.2
    • Component/s: None
    • Labels:
      None
    • Environment:

      JBoss 7.1.1

      Description

      The #run() and #release() methods required by javax.resource.spi.work.Work are expected by JBoss 7.1 to be overridden in the specific subclasses of Work used in an RA. Unfortunately, XADisk only declared these methods in abstract superclasses; the concrete implementations only inherit these.

      While this is perfectly fine with respect to the Spec, JBoss will refuse to load XADisk unless the subclasses override the methods from the abstract Work classes (overriding with super.run() / super.release()) is okay).

      While JBoss is quite certainly wrong here, XADisk will not load on JBoss 7.1; the attached patch fixes that (without changing behavior).

        Activity

        Hide
        Nitin Verma added a comment -

        Checked-in the changes to trunk.

        Show
        Nitin Verma added a comment - Checked-in the changes to trunk.
        Hide
        Nitin Verma added a comment -

        Hi Simon,

        Thanks for finding and reporting this.

        You may also be interested in some relevant information at http://groups.google.com/group/xadisk/browse_thread/thread/47b7324ece6b884a - refer to my posts on 7th and 10th April. Quoting below...

        "The second one is an issue in JBoss/iron-jacamar. One can either use
        the workaround you mentioned ("Ensure every Class in
        org.xadisk.filesystem.workers implements run()
        and release().") and create a new xadisk binary locally or hopefully
        it will be fixed soon in a JBoss release. Also, thanks for filing the
        iron-jacamar bug: https://community.jboss.org/message/728756."

        "The second issue, which was in JBoss/iron-jacamar, has been fixed
        through bug - https://issues.jboss.org/browse/JBJCA-789. This fix is
        available in iron-jacamar version 1.0.10.Final. Though, the latest
        version of JBoss AS, which is 7.1.1.Final as of today, uses iron-
        jacamar version 1.0.9.Final as per https://community.jboss.org/wiki/AS711FinalReleaseNotes.
        So, from the JBoss side, we will still have to wait till JBoss
        upgrades its iron-jacamar version further."

        Thanks,
        Nitin

        Show
        Nitin Verma added a comment - Hi Simon, Thanks for finding and reporting this. You may also be interested in some relevant information at http://groups.google.com/group/xadisk/browse_thread/thread/47b7324ece6b884a - refer to my posts on 7th and 10th April. Quoting below... "The second one is an issue in JBoss/iron-jacamar. One can either use the workaround you mentioned ("Ensure every Class in org.xadisk.filesystem.workers implements run() and release().") and create a new xadisk binary locally or hopefully it will be fixed soon in a JBoss release. Also, thanks for filing the iron-jacamar bug: https://community.jboss.org/message/728756 ." "The second issue, which was in JBoss/iron-jacamar, has been fixed through bug - https://issues.jboss.org/browse/JBJCA-789 . This fix is available in iron-jacamar version 1.0.10.Final. Though, the latest version of JBoss AS, which is 7.1.1.Final as of today, uses iron- jacamar version 1.0.9.Final as per https://community.jboss.org/wiki/AS711FinalReleaseNotes . So, from the JBoss side, we will still have to wait till JBoss upgrades its iron-jacamar version further." Thanks, Nitin

          People

          • Assignee:
            Nitin Verma
            Reporter:
            Simon Dierl
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: