xadisk
  1. xadisk
  2. XADISK-141

In GatheringDiskWriter, method writeRemainingBuffersNow should wait for processEvent to complete.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.1
    • Fix Version/s: 1.2.2
    • Component/s: filesystem
    • Labels:
      None

      Description

      In GatheringDiskWriter, method writeRemainingBuffersNow should wait for processEvent to complete. Else, there is a danger (not so reported till now, but in theory) of buffer re-ordering, where the processEvent could end-up writing the de-queued buffers for the same transaction AFTER writeRemainingBuffersNow does so (for the later buffers).

      Solution is to expand the scope of transactionLogLock while will ensure no interference. The locking was already there around the log-writing, but it should also enclose the de-queuing of buffers to make de-queue + log-writing atomic.

        Activity

        Hide
        Nitin Verma added a comment -

        Checked-in the changes to trunk.

        Show
        Nitin Verma added a comment - Checked-in the changes to trunk.

          People

          • Assignee:
            Nitin Verma
            Reporter:
            Nitin Verma
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: