xadisk
  1. xadisk
  2. XADISK-159

In NativeXAFileOutputStream.write, replace the recursive call to write with a loop.

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.2
    • Fix Version/s: current
    • Component/s: filesystem
    • Labels:
      None

      Description

      Thanks to Marco for sharing this over the discussion thread: https://groups.google.com/forum/#!topic/xadisk/n9xj3OuWW9o

      In NativeXAFileOutputStream.write, the recursive call to write can lead to a high number of stack frames (eg for 1M byte[] and with default xadisk buffer size of 4k, there would be around 250 recursive calls). Replace this with a loop alternative (the changes are going to be trivial).

        Activity

        Hide
        Nitin Verma added a comment -

        Checked-in the changes to trunk.

        Show
        Nitin Verma added a comment - Checked-in the changes to trunk.

          People

          • Assignee:
            Nitin Verma
            Reporter:
            Nitin Verma
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: